-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DebugExporter] Add EventName from LogRecord to output #11967
Open
cijothomas
wants to merge
12
commits into
open-telemetry:main
Choose a base branch
from
cijothomas:cijothomas/eventname-debug-exporter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[DebugExporter] Add EventName from LogRecord to output #11967
cijothomas
wants to merge
12
commits into
open-telemetry:main
from
cijothomas:cijothomas/eventname-debug-exporter
+69
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cijothomas
commented
Dec 20, 2024
trask
reviewed
Dec 20, 2024
Co-authored-by: Trask Stalnaker <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11967 +/- ##
=======================================
Coverage 91.62% 91.62%
=======================================
Files 447 447
Lines 23739 23741 +2
=======================================
+ Hits 21751 21753 +2
Misses 1613 1613
Partials 375 375 ☔ View full report in Codecov by Sentry. |
codeboten
reviewed
Dec 21, 2024
@codeboten The changelog CI check looks broken, unrelated to this PR. Could you help fix that, so this PR can have its CI check pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to tracking issue
Fixes #11966
Testing
Manually tested with Otel client that exported a LogRecord with event name and without event name.
(1st time contributor here, still learning the process.)