change strategy - beta version will default to Legacy (ie no change i…

…n semantic convention output). There will be a fast follow PR to remove Legacy in preparation for an RC.

src/OpenTelemetry.Instrumentation.AWS/.publicApi/PublicAPI.Unshipped.txt

@@ -1,5 +1,6 @@
 #nullable enable
 OpenTelemetry.Instrumentation.AWS.SemanticConventionVersion
+OpenTelemetry.Instrumentation.AWS.SemanticConventionVersion.Legacy = -1 -> OpenTelemetry.Instrumentation.AWS.SemanticConventionVersion
 OpenTelemetry.Instrumentation.AWS.SemanticConventionVersion.Latest = 0 -> OpenTelemetry.Instrumentation.AWS.SemanticConventionVersion
 OpenTelemetry.Instrumentation.AWS.SemanticConventionVersion.V1_29_0 = 2 -> OpenTelemetry.Instrumentation.AWS.SemanticConventionVersion
 OpenTelemetry.Instrumentation.AWS.SemanticConventionVersion.V1_28_0 = 1 -> OpenTelemetry.Instrumentation.AWS.SemanticConventionVersion

src/OpenTelemetry.Instrumentation.AWSLambda/.publicApi/PublicAPI.Unshipped.txt

@@ -1,4 +1,5 @@
 #nullable enable
+OpenTelemetry.Instrumentation.AWSLambda.SemanticConventionVersion.Legacy = -1 -> OpenTelemetry.Instrumentation.AWSLambda.SemanticConventionVersion
 OpenTelemetry.Instrumentation.AWSLambda.SemanticConventionVersion
 OpenTelemetry.Instrumentation.AWSLambda.SemanticConventionVersion.Latest = 0 -> OpenTelemetry.Instrumentation.AWSLambda.SemanticConventionVersion
 OpenTelemetry.Instrumentation.AWSLambda.SemanticConventionVersion.V1_29_0 = 2 -> OpenTelemetry.Instrumentation.AWSLambda.SemanticConventionVersion

src/OpenTelemetry.Resources.AWS/.publicApi/PublicAPI.Unshipped.txt

@@ -1,4 +1,5 @@
 OpenTelemetry.Resources.AWS.SemanticConventionVersion
+OpenTelemetry.Resources.AWS.SemanticConventionVersion.Legacy = -1 -> OpenTelemetry.Resources.AWS.SemanticConventionVersion
 OpenTelemetry.Resources.AWS.SemanticConventionVersion.Latest = 0 -> OpenTelemetry.Resources.AWS.SemanticConventionVersion
 OpenTelemetry.Resources.AWS.SemanticConventionVersion.V1_29_0 = 2 -> OpenTelemetry.Resources.AWS.SemanticConventionVersion
 OpenTelemetry.Resources.AWS.SemanticConventionVersion.V1_28_0 = 1 -> OpenTelemetry.Resources.AWS.SemanticConventionVersion

src/Shared/AWS/AWSSemanticConventions.cs

@@ -19,6 +19,9 @@
 #pragma warning disable SA1201
 #pragma warning disable SA1623
 
+// disable obsolete warning - remove in RC
+#pragma warning disable CS0618
+
 namespace OpenTelemetry.AWS;
 
 /// <summary>
@@ -66,7 +69,10 @@ internal partial class AWSSemanticConventions
     /// Per SemanticConventionVersion, default should stay as
     /// <see cref="SemanticConventionVersion.V1_28_0"/> until next major version bump.
     /// </remarks>
-    internal const SemanticConventionVersion DefaultSemanticConventionVersion = SemanticConventionVersion.V1_28_0;
+    internal const SemanticConventionVersion DefaultSemanticConventionVersion = SemanticConventionVersion.Legacy;
+
+    // RC Release: change to
+    //SemanticConventionVersion.V1_28_0;
 
     private readonly SemanticConventionVersion semanticConventionVersion;
 
@@ -488,6 +494,9 @@ private AWSSemanticConventionsBase GetSemanticConventionVersion()
             case SemanticConventionVersion.V1_28_0:
                 return new AWSSemanticConventions_V1_28_0();
 
+            case SemanticConventionVersion.Legacy:
+                return new AWSSemanticConventionsLegacy();
+
             default:
                 throw new InvalidEnumArgumentException(
                     argumentName: nameof(SemanticConventionVersion),

src/Shared/AWS/SemanticConventionVersion.cs

@@ -73,6 +73,18 @@ public enum SemanticConventionVersion
     /// </summary>
     Latest = 0,
 
+    /// <summary>
+    /// Represents the mixture of Semantic Conventions used in OpenTelemetry.*.AWS libraries
+    /// in 1.10.0-beta.x.
+    /// <para />
+    /// This allows users to upgrade to the latest beta nuget package without experiencing a change in
+    /// Semantic Convention output.  Then there is an opportunity for users to trial <see cref="V1_28_0"/>.
+    /// <para />
+    /// This option will be REMOVED in the next Release Candidate.
+    /// </summary>
+    [Obsolete("This will be removed in the 1.10.0-RC", error: false)]
+    Legacy = -1,
+
     /// <summary>
     /// Pin to the specific state of all Semantic Conventions as of the 1.28.0
     /// release. See: