Skip to content

Commit

Permalink
Update changelog/readme
Browse files Browse the repository at this point in the history
  • Loading branch information
alanwest committed Oct 25, 2024
1 parent 7d59557 commit e8790af
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
8 changes: 5 additions & 3 deletions src/OpenTelemetry.Instrumentation.SqlClient/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,13 @@
for the same information. Note that `server.address` is only included when
the `EnableConnectionLevelAttributes` option is enabled.
([#2229](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2229))
* When `EnableConnectionLevelAttributes` is enabled, the `server.port` attribute
will now be written as an integer to be compliant with the
[semantic conventions](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/attributes-registry/server.md).
* **Breaking change**: When `EnableConnectionLevelAttributes` is enabled, the
`server.port` attribute will now be written as an integer to be compliant with
the [semantic conventions](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/attributes-registry/server.md).
Previously, it was written as a string.
([#2233](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2233))
* The `EnableConnectionLevelAttributes` option is now enabled by default.
([#TBD](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/TBD))

## 1.9.0-beta.1

Expand Down
4 changes: 2 additions & 2 deletions src/OpenTelemetry.Instrumentation.SqlClient/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,8 @@ command text will be captured.
> [!NOTE]
> EnableConnectionLevelAttributes is supported on all runtimes.
By default, `EnabledConnectionLevelAttributes` is disabled.
If `EnabledConnectionLevelAttributes` is enabled,
By default, `EnabledConnectionLevelAttributes` is enabled.
When `EnabledConnectionLevelAttributes` is enabled,
the [`DataSource`](https://docs.microsoft.com/dotnet/api/system.data.common.dbconnection.datasource)
will be parsed and the server name or IP address will be sent as
the `server.address` attribute, the instance name will be sent as
Expand Down

0 comments on commit e8790af

Please sign in to comment.