[wcf] Add AspNet parent span correction

[repl-chris]

Fixes #1243

Changes

Execution context does not flow from ASP.NET to WCF, so when ASP.NET instrumentation is enabled the WCF span ends up being a sibling of the ASP.NET span, rather than a child of it. This PR hooks into the ASP.NET instrumentation and overrides the incoming request headers with the ASP.NET span, which forces it to propagate into WCF so we get the correct parent. Unfortunately, in order to do this it required reflection of a non-public property (NameValueCollection.IsReadOnly)...it's not ideal but it's the only way I could get it to work, and it will degrade gracefully back to the current behavior if it ever changes (but really, this is only for netframework so it won't ever change)

For significant contributions please make sure you have completed the following items:

• Appropriate CHANGELOG.md updated for non-trivial changes
• Design discussion issue #
• Changes in public API reviewed

[codecov]

Codecov Report

Merging #1342 (a22ba2b) into main (71655ce) will increase coverage by 5.87%.
Report is 13 commits behind head on main.
The diff coverage is 72.36%.

@@            Coverage Diff             @@
##             main    #1342      +/-   ##
==========================================
+ Coverage   73.91%   79.78%   +5.87%     
==========================================
  Files         267      174      -93     
  Lines        9615     4967    -4648     
==========================================
- Hits         7107     3963    -3144     
+ Misses       2508     1004    -1504     

Flag	Coverage Δ
unittests	79.87% <41.17%> (?)
unittests-Instrumentation.Wcf	79.20% <81.35%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...searchClient/ElasticsearchClientInstrumentation.cs	100.00% <100.00%> (ø)
...ityFrameworkCore/EntityFrameworkInstrumentation.cs	100.00% <100.00%> (ø)
...ation/EntityFrameworkInstrumentationEventSource.cs	12.00% <100.00%> (ø)
...Instrumentation.Quartz/QuartzJobInstrumentation.cs	83.33% <100.00%> (+1.51%)	⬆️
...rumentation.Wcf/TracerProviderBuilderExtensions.cs	88.88% <100.00%> (+1.38%)	⬆️
...ry.ResourceDetectors.AWS/AWSEBSResourceDetector.cs	92.00% <ø> (+0.69%)	⬆️
...ntation/ElasticsearchInstrumentationEventSource.cs	7.69% <16.66%> (-4.81%)	⬇️
...Implementation/QuartzInstrumentationEventSource.cs	33.33% <0.00%> (-16.67%)	⬇️
...cf/Implementation/WcfInstrumentationEventSource.cs	21.73% <0.00%> (-6.04%)	⬇️
...on.Wcf/Implementation/AspNetParentSpanCorrector.cs	88.67% <88.67%> (ø)

... and 109 files with indirect coverage changes

[Kielek]

As I remember usually we handle two cases (at least for internal tests visiblity) - with and withoud public key. Depending on library has this key or no.

[repl-chris]

I couldn't actually find anywhere referencing other assemblies using their strong name, so I've updated this one to be consistent with the others and just not include the PublicKeyToken at all.

[repl-chris]

@Kielek I have updated the new example to the new csproj format, and have addressed all other review comments. 👍

[Kielek]

@CodeBlanch. could you pleas also review?

[Kielek]

@repl-chris, question not related to this PR. You are havilly working on WCF instrumentation, it is great, any chance that you help with enabling nullable feature? See #894

Separate PR.

[repl-chris]

@repl-chris, question not related to this PR. You are havilly working on WCF instrumentation, it is great, any chance that you help with enabling nullable feature? See #894

Separate PR.

yeah, I can probably do the WCF-related projects 👍

[Kielek]

@CodeBlanch, @lachmatt, LGTM, could you please check it also?

[lachmatt]

LGTM

[CodeBlanch]

LGTM

[CodeBlanch]

@repl-chris I don't see a CHANGELOG update would you mind adding a note in there and then I think we are good to merge.

[repl-chris]

@CodeBlanch Added CHANGELOG, good to go 👍