Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OneCollectorExporter] Perf improvements #1361

Merged

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Sep 19, 2023

[These changes were originally part of #1327]

Changes

  • Adds the utf8 encoded json to what is stored in the extension cache
  • Adds a special case for IReadOnlyList<KeyValuePair<string, object?>> values in json serializer
  • Use raw string literals for JSON in tests
  • Improves the validation of extension fields to protect against invalid data

TODOs

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Unit tests updated

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #1361 (e564839) into main (8ff2bde) will increase coverage by 0.05%.
Report is 4 commits behind head on main.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1361      +/-   ##
==========================================
+ Coverage   73.86%   73.91%   +0.05%     
==========================================
  Files         266      267       +1     
  Lines        9596     9615      +19     
==========================================
+ Hits         7088     7107      +19     
  Misses       2508     2508              
Files Changed Coverage
...esourceDetectors.Azure/AzureVmMetaDataRequestor.cs 0.00%
...ector/Internal/ExtensionFieldInformationManager.cs 90.90%
...OneCollector/Internal/ExtensionFieldInformation.cs 100.00%
...rialization/CommonSchemaJsonSerializationHelper.cs 100.00%
...erialization/CommonSchemaJsonSerializationState.cs 100.00%

@utpilla utpilla added the comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector label Sep 19, 2023
@CodeBlanch CodeBlanch merged commit 71655ce into open-telemetry:main Sep 19, 2023
21 of 22 checks passed
@CodeBlanch CodeBlanch deleted the onecollector-perf-improvements branch September 19, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants