Nullable for tests-projects with already handled projects #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1370 +/- ##
==========================================
+ Coverage 73.91% 79.86% +5.94%
==========================================
Files 267 165 -102
Lines 9615 4703 -4912
==========================================
- Hits 7107 3756 -3351
+ Misses 2508 947 -1561
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
utpilla
reviewed
Oct 6, 2023
| @@ -41,6 +41,7 @@ public void AddTraceEnricherOfTRegistersEnricher() | |||
| using var source = new ActivitySource(SourceName); | |||
| using (var activity = source.StartActivity(SourceName)) | |||
| { | |||
| Assert.NotNull(activity); | |||
There was a problem hiding this comment.
We don't really need these Assert.NotNull(activity); statements. The unit tests would fail anyway if the activity ends up being null.
There was a problem hiding this comment.
I can use either use ! as null-forgiving operator or add this assertion. Assertion looks better IMO.
utpilla
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #894.
Changes
Nullable for tests-projects with already handled projects.
While reviewing consider to check each commit separately.
For significant contributions please make sure you have completed the following items:
[ ] AppropriateCHANGELOG.mdupdated for non-trivial changes[ ] Design discussion issue #[ ] Changes in public API reviewed