-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wcf] Streamline the exposed public interface (breaking change) #1376
Merged
CodeBlanch
merged 6 commits into
open-telemetry:main
from
repl-chris:StreamlinePublicInterface
Oct 2, 2023
Merged
[wcf] Streamline the exposed public interface (breaking change) #1376
CodeBlanch
merged 6 commits into
open-telemetry:main
from
repl-chris:StreamlinePublicInterface
Oct 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1376 +/- ##
==========================================
+ Coverage 73.91% 79.20% +5.28%
==========================================
Files 267 30 -237
Lines 9615 678 -8937
==========================================
- Hits 7107 537 -6570
+ Misses 2508 141 -2367
Flags with carried forward coverage won't be shown. Click here to find out more.
|
repl-chris
force-pushed
the
StreamlinePublicInterface
branch
from
September 27, 2023 16:12
d06db6d
to
ed84e3f
Compare
Kielek
approved these changes
Sep 27, 2023
Kielek
reviewed
Sep 27, 2023
Kielek
added
the
comp:instrumentation.wcf
Things related to OpenTelemetry.Instrumentation.Wcf
label
Sep 27, 2023
Co-authored-by: Piotr Kiełkowicz <[email protected]>
…hris/opentelemetry-dotnet-contrib into StreamlinePublicInterface
lachmatt
approved these changes
Oct 2, 2023
CodeBlanch
reviewed
Oct 2, 2023
CodeBlanch
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This moves the
TelemetryClientMessageInspector
andTelemetryDispatchMessageInspector
to be internal-only classes. The only documented/supported ways to use this library is via theTelemetryEndpointBehavior
,TelemetryServiceBehavior
, and/orTelemetryContractBehaviorAttribute
so there is no need for the message inspectors to be public. Technically this is a breaking change, however consumers are likely never referencing these classes directly today as there is no need or reason for them to - they provide no additional capabilities over the published/documented way to consume this library.For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes