Updates for .NET 8 code analysis - Part 2

[utpilla]

Towards #1437

Changes

• Fix the newer code analysis warnings from .NET 8 SDK
• Here a few common ones:
  • CA1859 Use concrete types when possible for improved performance
  • CA1510 Use ArgumentNullException throw helper

[codecov]

Codecov Report

Merging #1446 (ed743db) into main (71655ce) will decrease coverage by 1.06%.
Report is 58 commits behind head on main.
The diff coverage is 68.53%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1446      +/-   ##
==========================================
- Coverage   73.91%   72.86%   -1.06%     
==========================================
  Files         267      250      -17     
  Lines        9615     9282     -333     
==========================================
- Hits         7107     6763     -344     
- Misses       2508     2519      +11     

Flag	Coverage Δ
unittests-Exporter.Geneva	57.92% <31.48%> (?)
unittests-Exporter.OneCollector	89.72% <100.00%> (?)
unittests-Extensions	81.89% <100.00%> (?)
unittests-Instrumentation.AspNet	72.56% <94.44%> (?)
unittests-Instrumentation.EventCounters	75.92% <ø> (?)
unittests-Instrumentation.Owin	85.71% <100.00%> (?)
unittests-Instrumentation.Process	100.00% <ø> (?)
unittests-Instrumentation.Runtime	100.00% <ø> (?)
unittests-Instrumentation.StackExchangeRedis	71.37% <6.45%> (?)
unittests-Instrumentation.Wcf	78.33% <81.59%> (?)
unittests-PersistentStorage	58.80% <ø> (?)
unittests-ResourceDetectors.Azure	80.90% <60.00%> (?)
unittests-Solution	79.57% <76.78%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...xporter.Geneva/Internal/ConnectionStringBuilder.cs	92.94% <100.00%> (ø)
...r.Geneva/Metrics/GenevaMetricExporterExtensions.cs	93.33% <ø> (ø)
...orter.Geneva/MsgPackExporter/MsgPackLogExporter.cs	95.10% <100.00%> (+1.76%)	⬆️
...ter.Geneva/MsgPackExporter/MsgPackTraceExporter.cs	94.52% <100.00%> (+2.10%)	⬆️
...ry.Exporter.InfluxDB/InfluxDBExporterExtensions.cs	100.00% <100.00%> (ø)
....Exporter.OneCollector/Internal/CallbackManager.cs	96.00% <100.00%> (+0.16%)	⬆️
...ector/Internal/Transports/HttpJsonPostTransport.cs	95.41% <ø> (ø)
...er.OneCollector/Internal/Transports/IHttpClient.cs	100.00% <ø> (ø)
...ctor/Logs/OneCollectorLogExportProcessorBuilder.cs	67.74% <ø> (ø)
...ions.Enrichment/Internal/TraceEnrichmentActions.cs	100.00% <100.00%> (ø)
... and 64 more

... and 44 files with indirect coverage changes

[github-actions]

This PR was marked stale due to lack of activity. It will be closed in 7 days.