Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo] Remove .NET 7 target #2038

Merged
merged 8 commits into from
Sep 6, 2024
Merged

[repo] Remove .NET 7 target #2038

merged 8 commits into from
Sep 6, 2024

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Sep 5, 2024

Follow up to open-telemetry/opentelemetry-dotnet#5795
Preparation to #2034 (it solves at least some issues from the list).

Changes

Remove .NET 7 target

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@github-actions github-actions bot added the infra Infra work - CI/CD, code coverage, linters label Sep 5, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector comp:extensions.enrichment Things related to OpenTelemetry.Extensions.Enrichment comp:extensions Things related to OpenTelemetry.Extensions comp:instrumentation.aspnetcore Things related to OpenTelemetry.Instrumentation.AspNetCore comp:exporter.influxdb Things related to OpenTelemetry.Exporter.InfluxDB perf Performance related comp:instrumentation.cassandra Things related to OpenTelemetry.Instrumentation.Cassandra comp:instrumentation.entityframeworkcore Things related to OpenTelemetry.Instrumentation.EntityFrameworkCore comp:instrumentation.grpcnetclient Things related to OpenTelemetry.Instrumentation.GrpcNetClient comp:instrumentation.http Things related to OpenTelemetry.Instrumentation.Http comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient labels Sep 5, 2024
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.43%. Comparing base (71655ce) to head (67db15e).
Report is 404 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2038      +/-   ##
==========================================
+ Coverage   73.91%   75.43%   +1.51%     
==========================================
  Files         267      314      +47     
  Lines        9615    12057    +2442     
==========================================
+ Hits         7107     9095    +1988     
- Misses       2508     2962     +454     
Flag Coverage Δ
unittests-Exporter.Geneva 64.27% <ø> (?)
unittests-Exporter.InfluxDB 95.88% <ø> (?)
unittests-Exporter.Instana 71.24% <ø> (?)
unittests-Exporter.OneCollector 93.07% <ø> (?)
unittests-Exporter.Stackdriver 75.73% <ø> (?)
unittests-Extensions 88.57% <ø> (?)
unittests-Extensions.AWS 83.41% <ø> (?)
unittests-Extensions.Enrichment 100.00% <ø> (?)
unittests-Instrumentation.AWS 75.77% <ø> (?)
unittests-Instrumentation.AWSLambda 88.92% <ø> (?)
unittests-Instrumentation.AspNet 76.73% <ø> (?)
unittests-Instrumentation.AspNetCore 85.27% <ø> (?)
unittests-Instrumentation.ElasticsearchClient 79.87% <ø> (?)
unittests-Instrumentation.EntityFrameworkCore 55.49% <ø> (?)
unittests-Instrumentation.EventCounters 76.36% <ø> (?)
unittests-Instrumentation.GrpcNetClient 79.61% <ø> (?)
unittests-Instrumentation.Hangfire 93.58% <ø> (?)
unittests-Instrumentation.Http 82.06% <ø> (?)
unittests-Instrumentation.Owin 85.79% <ø> (?)
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-Instrumentation.Quartz 78.94% <ø> (?)
unittests-Instrumentation.Runtime 100.00% <ø> (?)
unittests-Instrumentation.SqlClient 90.90% <ø> (?)
unittests-Instrumentation.StackExchangeRedis 67.02% <ø> (?)
unittests-Instrumentation.Wcf 48.91% <ø> (?)
unittests-PersistentStorage 65.78% <ø> (?)
unittests-Resources.AWS 77.93% <ø> (?)
unittests-Resources.Azure 82.83% <ø> (?)
unittests-Resources.Container 72.41% <ø> (?)
unittests-Resources.Gcp 72.54% <ø> (?)
unittests-Resources.Host 72.64% <ø> (?)
unittests-Resources.OperatingSystem 79.68% <ø> (?)
unittests-Resources.Process 100.00% <ø> (?)
unittests-Resources.ProcessRuntime 77.08% <ø> (?)
unittests-Sampler.AWS 87.97% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ry.Exporter.Geneva/Metrics/GenevaMetricExporter.cs 97.05% <ø> (+30.39%) ⬆️
....Exporter.OneCollector/Internal/CallbackManager.cs 96.00% <ø> (+0.16%) ⬆️
...Internal/Serialization/BatchSerializationResult.cs 100.00% <ø> (ø)
...rialization/CommonSchemaJsonSerializationHelper.cs 100.00% <ø> (ø)
...lector/Internal/Transports/TransportSendRequest.cs 100.00% <ø> (ø)
...llector/OneCollectorExporterValidationException.cs 25.00% <ø> (ø)

... and 328 files with indirect coverage changes

@Kielek Kielek marked this pull request as ready for review September 5, 2024 09:14
@Kielek Kielek requested a review from a team September 5, 2024 09:14
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kielek Kielek merged commit 029077d into open-telemetry:main Sep 6, 2024
212 of 213 checks passed
@Kielek Kielek deleted the drop-net7 branch September 6, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva comp:exporter.influxdb Things related to OpenTelemetry.Exporter.InfluxDB comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector comp:extensions.enrichment Things related to OpenTelemetry.Extensions.Enrichment comp:extensions Things related to OpenTelemetry.Extensions comp:instrumentation.aspnetcore Things related to OpenTelemetry.Instrumentation.AspNetCore comp:instrumentation.cassandra Things related to OpenTelemetry.Instrumentation.Cassandra comp:instrumentation.entityframeworkcore Things related to OpenTelemetry.Instrumentation.EntityFrameworkCore comp:instrumentation.grpcnetclient Things related to OpenTelemetry.Instrumentation.GrpcNetClient comp:instrumentation.http Things related to OpenTelemetry.Instrumentation.Http comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient documentation Improvements or additions to documentation infra Infra work - CI/CD, code coverage, linters perf Performance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants