Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resources.AWS] Remove .NET 6 target and add .NET Standard 2.0 #2164

Merged
merged 5 commits into from
Oct 4, 2024

Conversation

joegoldman2
Copy link
Contributor

Changes

Replace .NET 6 target, which will be very soon out of support, with .NET 8 and add support for .NET Standard 2.0.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@joegoldman2 joegoldman2 requested a review from a team as a code owner October 4, 2024 08:54
@github-actions github-actions bot requested review from ppittle and srprash October 4, 2024 08:55
@github-actions github-actions bot added the comp:resources.aws Things related to OpenTelemetry.Resources.AWS label Oct 4, 2024
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.85%. Comparing base (71655ce) to head (78aa4be).
Report is 508 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2164      +/-   ##
==========================================
+ Coverage   73.91%   77.85%   +3.93%     
==========================================
  Files         267       12     -255     
  Lines        9615      289    -9326     
==========================================
- Hits         7107      225    -6882     
+ Misses       2508       64    -2444     
Flag Coverage Δ
unittests-Resources.AWS 77.85% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/OpenTelemetry.Resources.AWS/AWSECSDetector.cs 87.87% <ø> (ø)
src/OpenTelemetry.Resources.AWS/AWSEKSDetector.cs 57.89% <100.00%> (ø)
...etry.Resources.AWS/AWSResourceBuilderExtensions.cs 0.00% <ø> (ø)
...enTelemetry.Resources.AWS/ResourceDetectorUtils.cs 100.00% <ø> (ø)

... and 272 files with indirect coverage changes

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch merged commit 98a36c8 into open-telemetry:main Oct 4, 2024
59 checks passed
@joegoldman2 joegoldman2 deleted the resourcesaws-tfm branch October 5, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:resources.aws Things related to OpenTelemetry.Resources.AWS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants