Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resources.AWS] Use System.Text.Json source generator with .NET Standard 2.0 #2185

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

joegoldman2
Copy link
Contributor

Changes

.NET Standard 2.0 target has been added to this package recently, but preprocessor directives have not been updated to use STJ source generator for this target as well.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@joegoldman2 joegoldman2 requested a review from a team as a code owner October 5, 2024 09:30
@github-actions github-actions bot added the comp:resources.aws Things related to OpenTelemetry.Resources.AWS label Oct 5, 2024
@github-actions github-actions bot requested review from ppittle and srprash October 5, 2024 09:30
Copy link

codecov bot commented Oct 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.85%. Comparing base (71655ce) to head (828f900).
Report is 515 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2185      +/-   ##
==========================================
+ Coverage   73.91%   77.85%   +3.93%     
==========================================
  Files         267       12     -255     
  Lines        9615      289    -9326     
==========================================
- Hits         7107      225    -6882     
+ Misses       2508       64    -2444     
Flag Coverage Δ
unittests-Resources.AWS 77.85% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/OpenTelemetry.Resources.AWS/AWSEBSDetector.cs 92.59% <100.00%> (ø)
src/OpenTelemetry.Resources.AWS/AWSEC2Detector.cs 74.28% <100.00%> (ø)
...enTelemetry.Resources.AWS/ResourceDetectorUtils.cs 100.00% <100.00%> (ø)

... and 273 files with indirect coverage changes

@CodeBlanch CodeBlanch merged commit b424269 into open-telemetry:main Oct 7, 2024
59 checks passed
@joegoldman2 joegoldman2 deleted the aws-jsonsourcegen branch October 7, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:resources.aws Things related to OpenTelemetry.Resources.AWS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants