Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EntityFrameworkCore.Tests] Replace hardcoded TFM #2201

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

joegoldman2
Copy link
Contributor

Changes

Addresses #2192 (comment).

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@joegoldman2 joegoldman2 requested a review from a team as a code owner October 10, 2024 05:55
@github-actions github-actions bot added the comp:instrumentation.entityframeworkcore Things related to OpenTelemetry.Instrumentation.EntityFrameworkCore label Oct 10, 2024
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch changed the title [EntityFrameworkCore.Tests] Remplace hardcoded TFM [EntityFrameworkCore.Tests] Replace hardcoded TFM Oct 10, 2024
@CodeBlanch CodeBlanch merged commit d51c9f4 into open-telemetry:main Oct 10, 2024
52 of 56 checks passed
@joegoldman2 joegoldman2 deleted the remove-hardcoded-tfm branch October 10, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.entityframeworkcore Things related to OpenTelemetry.Instrumentation.EntityFrameworkCore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants