Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[onecollector] Fix duplicate extension field bug #2205

Merged
merged 3 commits into from
Oct 11, 2024
Merged

[onecollector] Fix duplicate extension field bug #2205

merged 3 commits into from
Oct 11, 2024

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Oct 11, 2024 •
edited
Loading

Changes

  • Reset the extension field serialization state for each item being serialized to fix a bug causing extension fields from earlier records to be applied to later records in a batch.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes

@CodeBlanch CodeBlanch requested a review from a team as a code owner October 11, 2024 05:41
@github-actions github-actions bot requested a review from reyang October 11, 2024 05:41
@github-actions github-actions bot added the comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector label Oct 11, 2024
@CodeBlanch CodeBlanch merged commit 55b65bd into open-telemetry:main Oct 11, 2024
55 of 61 checks passed
@CodeBlanch CodeBlanch deleted the onecollector-extension-dupes branch October 11, 2024 16:49
CodeBlanch added a commit to CodeBlanchOrg/opentelemetry-dotnet-contrib that referenced this pull request Oct 11, 2024
@CodeBlanch
[onecollector] Fix duplicate extension field bug (open-telemetry#2205)
8159df5
@CodeBlanch CodeBlanch mentioned this pull request Oct 11, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajkumar-rangaraj rajkumar-rangaraj rajkumar-rangaraj approved these changes

@Kielek Kielek Kielek approved these changes

@reyang reyang Awaiting requested review from reyang

Assignees

@reyang reyang

@CodeBlanch CodeBlanch

Labels
comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CodeBlanch @Kielek @rajkumar-rangaraj @reyang