Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[redis] Prepare to .NET9 #2252

Merged
merged 4 commits into from
Oct 28, 2024

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Oct 28, 2024

Changes

Follow up #2251

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • [ ] Unit tests added/updated
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@Kielek Kielek requested a review from a team as a code owner October 28, 2024 06:09
@github-actions github-actions bot requested a review from matt-hensley October 28, 2024 06:09
@github-actions github-actions bot added the comp:instrumentation.stackexchangeredis Things related to OpenTelemetry.Instrumentation.StackExchangeRedis label Oct 28, 2024
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 72.66%. Comparing base (71655ce) to head (aa5cde8).
Report is 552 commits behind head on main.

Files with missing lines Patch % Lines
...mentation/RedisProfilerEntryToActivityConverter.cs 0.00% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2252      +/-   ##
==========================================
- Coverage   73.91%   72.66%   -1.26%     
==========================================
  Files         267      358      +91     
  Lines        9615    13249    +3634     
==========================================
+ Hits         7107     9627    +2520     
- Misses       2508     3622    +1114     
Flag Coverage Δ
unittests-Contrib.Shared.Tests 83.17% <100.00%> (?)
unittests-Exporter.Geneva 62.69% <ø> (?)
unittests-Exporter.InfluxDB 95.88% <ø> (?)
unittests-Exporter.Instana 71.24% <ø> (?)
unittests-Exporter.OneCollector 94.34% <ø> (?)
unittests-Exporter.Stackdriver 75.73% <ø> (?)
unittests-Extensions 88.63% <ø> (?)
unittests-Extensions.Enrichment 100.00% <ø> (?)
unittests-Instrumentation.AWS 86.09% <ø> (?)
unittests-Instrumentation.AspNet 76.73% <ø> (?)
unittests-Instrumentation.AspNetCore 70.06% <ø> (?)
unittests-Instrumentation.ConfluentKafka 14.12% <ø> (?)
unittests-Instrumentation.ElasticsearchClient 79.87% <ø> (?)
unittests-Instrumentation.EntityFrameworkCore 57.06% <ø> (?)
unittests-Instrumentation.EventCounters 76.36% <ø> (?)
unittests-Instrumentation.GrpcNetClient 79.61% <ø> (?)
unittests-Instrumentation.Hangfire 93.58% <ø> (?)
unittests-Instrumentation.Http 60.59% <ø> (?)
unittests-Instrumentation.Owin 85.97% <ø> (?)
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-Instrumentation.Quartz 78.94% <ø> (?)
unittests-Instrumentation.Runtime 97.53% <ø> (?)
unittests-Instrumentation.SqlClient 91.36% <ø> (?)
unittests-Instrumentation.StackExchangeRedis 71.21% <46.15%> (?)
unittests-Instrumentation.Wcf 78.47% <ø> (?)
unittests-PersistentStorage 65.78% <ø> (?)
unittests-Resources.AWS 79.16% <ø> (?)
unittests-Resources.Azure 84.56% <ø> (?)
unittests-Resources.Container 67.34% <ø> (?)
unittests-Resources.Gcp 71.15% <ø> (?)
unittests-Resources.Host 73.04% <ø> (?)
unittests-Resources.OperatingSystem 76.98% <ø> (?)
unittests-Resources.Process 100.00% <ø> (?)
unittests-Resources.ProcessRuntime 78.26% <ø> (?)
unittests-Sampler.AWS 87.74% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...dis/StackExchangeRedisConnectionInstrumentation.cs 95.58% <100.00%> (-1.48%) ⬇️
...ExchangeRedis/StackExchangeRedisInstrumentation.cs 100.00% <100.00%> (ø)
src/Shared/PropertyFetcher.AOT.cs 97.95% <100.00%> (ø)
...mentation/RedisProfilerEntryToActivityConverter.cs 40.00% <0.00%> (-39.80%) ⬇️

... and 373 files with indirect coverage changes

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch changed the title [repo/Redis] Prepare to .NET9 [redis] Prepare to .NET9 Oct 28, 2024
@Kielek Kielek merged commit b9553c3 into open-telemetry:main Oct 28, 2024
128 of 129 checks passed
@Kielek Kielek deleted the net9prep-stackexchangeredis branch October 28, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.stackexchangeredis Things related to OpenTelemetry.Instrumentation.StackExchangeRedis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants