-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[repo] Remove #nullable enable #2290
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
assigned cijothomas, CodeBlanch, rajkumar-rangaraj, reyang, utpilla, Yun-Ting and zivaninstana
Nov 4, 2024
github-actions
bot
requested review from
cijothomas,
CodeBlanch,
rajkumar-rangaraj,
reyang,
utpilla,
Yun-Ting and
zivaninstana
November 4, 2024 12:34
github-actions
bot
added
comp:instrumentation.process
Things related to OpenTelemetry.Instrumentation.Process
comp:exporter.geneva
Things related to OpenTelemetry.Exporter.Geneva
comp:exporter.instana
Things related to OpenTelemetry.Instrumentation.Instana
comp:instrumentation.aspnetcore
Things related to OpenTelemetry.Instrumentation.AspNetCore
labels
Nov 4, 2024
CodeBlanch
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp:exporter.geneva
Things related to OpenTelemetry.Exporter.Geneva
comp:exporter.instana
Things related to OpenTelemetry.Instrumentation.Instana
comp:instrumentation.aspnetcore
Things related to OpenTelemetry.Instrumentation.AspNetCore
comp:instrumentation.process
Things related to OpenTelemetry.Instrumentation.Process
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up: #2251
Towards #894
Changes
Remove #nullable enable
in addition, it disables nullable per-file in Geneva.tests.
It is done to avoid IDE0240 while migrating to .NET9
Merge requirement checklist
[ ] AppropriateCHANGELOG.md
files updated for non-trivial changes[ ] Changes in public API reviewed (if applicable)