[PoC] Split EnabledParameters into read-write and read-only types #5820
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof-of-concept for refactoring the
EnabledParameters
into a read-only type. AEnabledParametersBuilder
type is added to act as a read-write type that wrapsEnabledParameters
.In response to #5816 (comment)
The basic idea is a user will create a
EnabledParametersBuilder
and pass the builtEnabledParameters
to theLogger.Enabled
method:The
EnabledParametersBuilder
type can be reused as it passes a static copy ofEnabledParameters
every timeBuild
is called.This means that any Logger, and subsequently any
Processor
in the SDK, will receive a read-only type. If they wish to update this type they can always create a new copy ofEnabledParameters
by doing something like this: