mark URLRequest as inout parameter

open-telemetry · Dec 20, 2024 · 9e7e791 · 9e7e791
1 parent 583407c
commit 9e7e791
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/Sources/Instrumentation/URLSession/URLSessionInstrumentationConfiguration.swift b/Sources/Instrumentation/URLSession/URLSessionInstrumentationConfiguration.swift
@@ -25,7 +25,7 @@ public struct URLSessionInstrumentationConfiguration {
                 receivedResponse: ((URLResponse, DataOrFile?, Span) -> Void)? = nil,
                 receivedError: ((Error, DataOrFile?, HTTPStatus, Span) -> Void)? = nil,
                 delegateClassesToInstrument: [AnyClass]? = nil,
-                baggageProvider: ((URLRequest, Span?) -> (Baggage)?)? = nil)
+                baggageProvider: ((inout URLRequest, Span?) -> (Baggage)?)? = nil)
     {
         self.shouldRecordPayload = shouldRecordPayload
         self.shouldInstrument = shouldInstrument
@@ -85,6 +85,6 @@ public struct URLSessionInstrumentationConfiguration {
     ///
     /// Note: The injected baggage depends on the propagator in use (e.g., W3C or custom).
     /// Returns: A `Baggage` instance or `nil` if no baggage is needed.
-    public let baggageProvider: ((URLRequest, Span?) -> (Baggage)?)?
+    public let baggageProvider: ((inout URLRequest, Span?) -> (Baggage)?)?
 
 }
diff --git a/Sources/Instrumentation/URLSession/URLSessionLogger.swift b/Sources/Instrumentation/URLSession/URLSessionLogger.swift
@@ -157,12 +157,12 @@ class URLSessionLogger {
             return nil
         }
         instrumentation.configuration.injectCustomHeaders?(&request, span)
+        let customBaggage = instrumentation.configuration.baggageProvider?(&request, span)
+
         var instrumentedRequest = request
         objc_setAssociatedObject(instrumentedRequest, URLSessionInstrumentation.instrumentedKey, true, .OBJC_ASSOCIATION_COPY_NONATOMIC)
         let propagators = OpenTelemetry.instance.propagators
 
-        let customBaggage = instrumentation.configuration.baggageProvider?(request, span)
-
         var traceHeaders = tracePropagationHTTPHeaders(span: span,
                                                        customBaggage: customBaggage,
                                                        textMapPropagator: propagators.textMapPropagator,