Update OtlpHttpTraceExporter init to support envVarHeaders #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djpearce
requested review from
nachoBonafonte,
bryce-b and
vvydier
as code owners
The committers listed above are authorized under a signed CLA. |
bryce-b
approved these changes
Oct 30, 2024
|
@djpearce, we appreciate your contribution. This looks great, we just need you to sign the CLA and I can get this merged. |
Just updated! |
vvydier
approved these changes
Oct 30, 2024
|
@bryce-b I think I'm waiting on y'all to merge this. Let me know if there is anything you need from me though. |
nachoBonafonte
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OtlpHttpTraceExporter init wasn't passing along the envVarHeaders to the super.init() call.
Seems like a mistake as our implementation wouldn't work without the authorization headers passed along.