Fix issue in read_bam implementation, it got the wrong contig name #206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pysam
'srname
actually returns the index of the contig instead of the contig name (which is poor naming on their end, but they deprecated that API).We should use
reference_name
instead to get the contig nameAlso added 2 integration tests for reading
bam
andsam
files, None forcram
because it would require afasta
and I don't have a dummy one to use.Fixed a bug in the json serialization, where if the tag was a list it ended up not being serializable (probably an edge case, but the dummy samtools test file had one)
Also added filetype inference to be able to read sam and cram files