Added Roboto Font to the app #172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@therajanmaurya please review and merge this PR :) |
|
@batbrain7 We are not going to add fonts in our app. we will use downloadable fonts and how downloadable fonts work please see the second link. I think you missed to read issue description. Please check again and here the link to implement the downloadable font: https://developer.android.com/guide/topics/ui/look-and-feel/downloadable-fonts.htmt. |
|
The first reason to not use your present implementation. It's making code messier and it's increasing the APK size. we don't want it, not even a single kb. |
|
@therajanmaurya please merge this PR, I updated this with the suggested changes quite a time ago now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #159
Added Roboto Font to the app using downloadable fonts as described in the link provided in the issue description.