Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Survey-Question-Logic-Implemented #2262

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

sujalagrawal2
Copy link

Fixes JIRA

Please Add Screenshots If there are any UI changes.

survey_question_video.mp4

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Apply the MifosStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

Comment on lines 85 to 86
viewModel: SurveySubmitViewModel = hiltViewModel(),
queViewModel: SurveyQuestionViewModel = hiltViewModel(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

submitViewmodel
quesViewmodel / questionViewmodel

Comment on lines 89 to 90
val uiState2 by queViewModel.surveyQuestionUiState.collectAsStateWithLifecycle()
val uiState by viewModel.surveySubmitUiState.collectAsStateWithLifecycle()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

choose an appropriate name, don't just do uiState , uiState2. its confusing,

@@ -79,68 +81,107 @@ import java.util.Date
@Composable
internal fun SurveyQuestionScreen(
navigateBack: () -> Unit,
survey: Survey?,
id: Int,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont pass id in here, retrieve it from viewmodel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants