fix: Run report view horizontal scroll issue

openMF · Aug 22, 2024 · c3776fb · c3776fb
1 parent bf93f6c
commit c3776fb
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 10 deletions.
diff --git a/...loan-product-stepper/loan-product-settings-step/loan-product-settings-step.component.html b/...loan-product-stepper/loan-product-settings-step/loan-product-settings-step.component.html
@@ -158,7 +158,7 @@ <h4 fxFlex="98%" class="mat-h4 m-r-10">{{'labels.inputs.Moratorium' | translate}
       </mat-select>
       <button mat-button *ngIf="loanProductSettingsForm.controls.delinquencyBucketId" matSuffix mat-icon-button
         aria-label="Clear" (click)="clearProperty($event, 'delinquencyBucketId')">
-        <mat-icon>close</mat-icon>
+        <i class="fa fa-close"></i>
       </button>
     </mat-form-field>
 

diff --git a/src/app/reports/run-report/run-report.component.ts b/src/app/reports/run-report/run-report.component.ts
@@ -125,8 +125,10 @@ export class RunReportComponent implements OnInit {
         } else { // Child Parameter
           const parent: ReportParameter = this.paramData
             .find((entry: any) => entry.name === param.parentParameterName);
-          parent.childParameters.push(param);
-          this.updateParentParameters(parent);
+          if (parent != null) {
+            parent.childParameters.push(param);
+            this.updateParentParameters(parent);
+          }
         }
       });
     if (this.isPentahoReport()) {

diff --git a/src/app/reports/run-report/table-and-sms/table-and-sms.component.scss b/src/app/reports/run-report/table-and-sms/table-and-sms.component.scss
@@ -1,11 +1,16 @@
+.table-output {
+  overflow: auto;
+}
+
 .select-row:hover {
-    cursor: pointer;
-  }
+  cursor: pointer;
+}
 
-.mat-header-cell, .mat-cell {
-    min-width: 150px;
-    margin-left: 5px;
-    margin-right: 5px;
+.mat-header-cell,
+.mat-cell {
+  min-width: 150px;
+  margin-left: 5px;
+  margin-right: 5px;
 }
 
 .back-button {
@@ -95,4 +100,4 @@ $color: #e2e4ec;
   100% {
     width: $bar;
   }
-}
+}