Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CA4FieldOfHippocampus.jsonld #179

Merged
merged 4 commits into from
Nov 4, 2024

Conversation

spieschnik
Copy link
Contributor

issue #178

@spieschnik spieschnik requested review from lzehl and UlrikeS91 October 25, 2024 09:54
Copy link
Contributor

@UlrikeS91 UlrikeS91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to follow a specific logic for these terms so that we can populate any and all UBERON parcellations programmatically. I have all terms stored locally (which need updating due to the change of our namespace) and #134 is a first PR for those. This is described in #133.

Could you please revise your PR with the content (but not the namespace!) of this instance:

{
  "@context": {
    "@vocab": "https://openminds.ebrains.eu/vocab/"
  },
  "@id": "https://openminds.ebrains.eu/instances/UBERONParcellation/CA4FieldOfHippocampus",
  "@type": "https://openminds.ebrains.eu/controlledTerms/UBERONParcellation",
  "definition": "Is a hippocampal field. [auto-generated from 'is_a' property of the [UBERON ontology term](http://purl.obolibrary.org/obo/UBERON_0003884)]",
  "description": "The last of four regions in the cornu ammonis of the hippocampus and is also part of the hilus of the dentate gyrus. This area contains mostly mossy cells that receive inputs from the dentate gyrus and pyramidal cells in the CA3 region and also projects back to the dentate gyrus. [definition of the [UBERON ontology term](http://purl.obolibrary.org/obo/UBERON_0003884)]",
  "interlexIdentifier": null,
  "knowledgeSpaceLink": "https://knowledge-space.org/wiki/UBERON:0003884#ca4-field-of-hippocampus",
  "name": "CA4 field of hippocampus",
  "preferredOntologyIdentifier": "http://purl.obolibrary.org/obo/UBERON_0003884",
  "synonym": [
    "CA4",
    "CA4 field",
    "CA4 field of Ammon's horn",
    "CA4 field of cornu ammonis",
    "hippocampus CA4",
    "regio IV cornus ammonis",
    "regio IV hippocampi proprii",
    "region 4 of Ammon's horn",
    "region IV of ammon's horn",
    "region IV of hippocampus proper"
  ]
}

revised to fit other UBERON parcellations
@spieschnik
Copy link
Contributor Author

Thanks @UlrikeS91, I revised the PR with the content you provided. Hope it fits now!

@spieschnik spieschnik requested a review from UlrikeS91 November 4, 2024 10:14
@UlrikeS91
Copy link
Contributor

Sorry for the late response! Content and name space of the updated file are great. Since the auto-population into the version folders isn't running yet, could you also create corresponding files for v4.0 and v3.0 folders? The v4.0 file is identical to the latest file, but v3.0 would actually have the old namespace.

Have a look at this merged PR which also had that: #167.

@spieschnik
Copy link
Contributor Author

Sure, you can check the new files now

@UlrikeS91 UlrikeS91 merged commit 024b261 into openMetadataInitiative:main Nov 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants