-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Another take to use arch when selecting repo for build target #1097
base: master
Are you sure you want to change the base?
Conversation
* [ ] trace the role of `no_repo` * [ ] trace the role of `repo_names` * [ ] check offline logic is not broken (check that offline still needed a non-empty repo list before this change)
Codecov Report
@@ Coverage Diff @@
## master #1097 +/- ##
==========================================
- Coverage 22.95% 22.95% -0.01%
==========================================
Files 27 27
Lines 16368 16373 +5
==========================================
Hits 3758 3758
- Misses 12610 12615 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
It is a string comparison of arch that |
So it returns the same repo multiple times with different arch |
Does not work for me: localhost:~/home:michals/vertest # osc -d build |
That was a mistake indeed. Fixed that part. |
Looks like this works, thanks osc -d build |
This pull request has been in a draft state for quite some time. |
@dmach it looks like this PR improves error messages, but I don't remember what I was trying to do and if it reaches that point. Feel free to close it if it has no value. |
This is another attempt to solve problem that
osc build
selectsOpenSuse_Tumbleweed
even if this selection doesn't fit the required architecture.#241 (comment)
no_repo
repo_names
needed a non-empty repo list before this change)