Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another take to use arch when selecting repo for build target #1097

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

abitrolly
Copy link
Contributor

This is another attempt to solve problem that osc build selects OpenSuse_Tumbleweed even if this selection doesn't fit the required architecture.

#241 (comment)

  • trace the role of no_repo
  • trace the role of repo_names
  • check offline logic is not broken (check that offline still
    needed a non-empty repo list before this change)

* [ ] trace the role of `no_repo`
* [ ] trace the role of `repo_names`
* [ ] check offline logic is not broken (check that offline still
      needed a non-empty repo list before this change)
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #1097 (e1dcec7) into master (43337af) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1097      +/-   ##
==========================================
- Coverage   22.95%   22.95%   -0.01%     
==========================================
  Files          27       27              
  Lines       16368    16373       +5     
==========================================
  Hits         3758     3758              
- Misses      12610    12615       +5     
Impacted Files Coverage Δ
osc/commandline.py 14.76% <0.00%> (-0.02%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hramrach
Copy link

hramrach commented Aug 3, 2022

r.arch == arg_arch looks fishy, shouldn't there be a list somewhere?

@abitrolly
Copy link
Contributor Author

It is a string comparison of arch that osc repos gives.

@hramrach
Copy link

hramrach commented Aug 3, 2022

So it returns the same repo multiple times with different arch

@hramrach
Copy link

hramrach commented Aug 3, 2022

Does not work for me:

localhost:~/home:michals/vertest # osc -d build
hostarch: armv7l
arg_arch: armv7l
arg_repository: None
arg_descr: None
no configured repos for arch armv7l

@abitrolly
Copy link
Contributor Author

That was a mistake indeed. Fixed that part.

@hramrach
Copy link

hramrach commented Aug 3, 2022

Looks like this works, thanks

osc -d build
hostarch: armv7l
arg_arch: armv7l
arg_repository: None
arg_descr: None
Building vertest.spec for openSUSE_Leap_15.2_Ports/armv7l

@dmach
Copy link
Contributor

dmach commented Mar 9, 2023

This pull request has been in a draft state for quite some time.
Could you either finish it, close it or add a comment that you're still planning to work on it?

@abitrolly abitrolly marked this pull request as ready for review March 9, 2023 18:38
@abitrolly
Copy link
Contributor Author

@dmach it looks like this PR improves error messages, but I don't remember what I was trying to do and if it reaches that point. Feel free to close it if it has no value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants