Allow osc rpmlint to infer prj/pkg from CWD.
#1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes `osc rpmlint` infer the project and package when working from a locally checked out package dir, if two or fewer arguments are passed. All four arguments are still required when called from a location that is not an osc package working copy. This makes the behaviour of `osc rpmlint` similar to `osc buildlogtail`.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1497 +/- ##
==========================================
- Coverage 31.51% 31.41% -0.11%
==========================================
Files 51 71 +20
Lines 17945 18486 +541
==========================================
+ Hits 5656 5807 +151
- Misses 12289 12679 +390 ☔ View full report in Codecov by Sentry. |
|
Looks good to me, merging. |
|
Thanks for the quick response and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
osc rpmlintinfer the project and package when working from a locally checked out package dir, if two or fewer arguments are passed. All four arguments are still required when called from a location that is not an osc package working copy.This makes the behaviour of
osc rpmlintsimilar toosc buildlogtail.