Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate #404

Open
wants to merge 7 commits into
base: 1.3.x
Choose a base branch
from
Open

Isolate #404

wants to merge 7 commits into from

Conversation

ktemple-wt
Copy link
Contributor

@ktemple-wt ktemple-wt commented Feb 19, 2019

Description

This pull request includes changes needed to ensure smooth operation of a containerized CICD pipeline for Nimbus Core.

Overview of Changes

  • Manage the project version number from a single location (a Maven config file)
  • Use Chrome Headless settings that are compatible with Chrome/Chromium 59+
  • Include the OSSRH snapshots and staging repositories in pom.xml

Type of Change

  • New feature
  • Bug fix
  • Refactor/Technical Debt
  • Documentation Update
  • Test case change
  • This change requires a documentation update
  • Other

Test Details

When you set your version number in the file at .mvn/maven.config, you will see a build with your version when you run mvn clean install -P cicdbuild -Dgpg.skip -DskipDocker

Additional Notes

More information about how the .mvn/maven.config file can be found here: https://maven.apache.org/docs/3.3.1/release-notes.html

The config file can take multiple Maven CLI arguments. The build script will rely on the version number being the very last value in the .mvn/maven.config file.

maven-wrapper had to be moved to the project root for proper behavior from the .mvn/maven.config file, given the project's structure.

This configuration should work in all environments. The target environment is a Ubuntu-based Docker image that can be found here: https://hub.docker.com/r/antheminc/build-env

@openanthem-admin
Copy link
Contributor

You did it @ktemple-wt!

Thank you for signing the Anthem Opensource Software CLA.

@lopezton-anthem
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants