Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add factory reset #15

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Add factory reset #15

merged 3 commits into from
Oct 23, 2023

Conversation

prinikasn
Copy link
Collaborator

No description provided.

@prinikasn prinikasn marked this pull request as draft October 20, 2023 22:03
@prinikasn prinikasn marked this pull request as ready for review October 22, 2023 02:20
greg-dennis
greg-dennis suggested changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@greg-dennis greg-dennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the build failure

@prinikasn
Copy link
Collaborator Author

Please fix the build failure

For this PR I will remove RetainCerts field. I will create another PR to add this and merge once a new gnoi release is available.

@prinikasn prinikasn requested a review from greg-dennis October 23, 2023 20:29
@prinikasn prinikasn merged commit 509fa04 into main Oct 23, 2023
3 checks passed
@prinikasn prinikasn deleted the factoryreset branch October 23, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg-dennis greg-dennis greg-dennis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prinikasn @greg-dennis