Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: *: refactor to use strong types #15

Closed
wants to merge 1 commit into from

Conversation

runcom
Copy link
Member

@runcom runcom commented Apr 26, 2017

Will take care of #14

  • get rid of all the proxy functions in the label pkg, just use selinux no?
  • the state struct in selinux smells
  • OTHERS

This is heavy WIP and I don't expect we'll finish it anytime soon, but it's to start discussing what @cpuguy83 proposed. We need to work together to ensure a pretty interface for pkg users as, right now, it's pretty awful.

@cpuguy83 @mrunalp @rhatdan PTAL

Signed-off-by: Antonio Murdaca [email protected]

Signed-off-by: Antonio Murdaca <[email protected]>
@runcom
Copy link
Member Author

runcom commented Apr 26, 2017

@cpuguy83 how would you use the new Label and/or Context struct? in daemon/create.go? Will HostConfig have a strong type for the SecurityOpts field?

@cpuguy83
Copy link
Contributor

@runcom Docker will continue to have to support the sec-opt format sadly, but at least we can parse into the new type.
With moby-project a more well structured API is on the table for sure.

@rhatdan
Copy link
Collaborator

rhatdan commented Jun 21, 2017

@runcom Could you get this rebased and we can take a look at it,

@rhatdan
Copy link
Collaborator

rhatdan commented Apr 7, 2020

Closing since this never moved forward.

@rhatdan rhatdan closed this Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants