Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

refactor: Replace listView with recyclerView for Discussion Screen #1821

Merged
merged 5 commits into from
Sep 19, 2023
Merged

refactor: Replace listView with recyclerView for Discussion Screen #1821

merged 5 commits into from
Sep 19, 2023

Conversation

omerhabib26
Copy link
Contributor

Description

LEARNER-9578

  • Replace listView with recyclerView on CourseDiscussionTopicsFragment, CourseDiscussionPostsThreadFragment and CourseDiscussionPostsSearchFragment
  • Update BaseListAdapters with RecyclerView Adapters
  • Optimise Code and usage including Java to kotlin conversion
  • Add Extensions methods for multiple Views

@omerhabib26
refactor: Replace listView with recyclerView for Discussion Screen
d2676b0 
- Replace listView with recyclerView on CourseDiscussionTopicsFragment, CourseDiscussionPostsThreadFragment and CourseDiscussionPostsSearchFragment
- Update BaseListAdapters with RecyclerView Adapters
- Optimise Code and usage including Java to kotlin conversion
- Add Extensions methods for multiple Views

fix: LEARNER-9578
@codecov
Copy link

codecov bot commented Sep 12, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (3c3eec3) 1.09% compared to head (ea928d9) 1.09%.
Report is 4 commits behind head on app_nav.

❗ Current head ea928d9 differs from pull request most recent head 8198682. Consider uploading reports for the commit 8198682 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff              @@
##             app_nav   #1821      +/-   ##
============================================
- Coverage       1.09%   1.09%   -0.01%     
  Complexity       137     137              
============================================
  Files            536     536              
  Lines          25819   25862      +43     
  Branches        3300    3296       -4     
============================================
  Hits             284     284              
- Misses         25508   25551      +43     
  Partials          27      27
Files Changed Coverage Δ
...ain/java/org/edx/mobile/extenstion/ImageViewExt.kt 0.00% <0.00%> (ø)
...main/java/org/edx/mobile/extenstion/TextViewExt.kt 0.00% <0.00%> (ø)
...src/main/java/org/edx/mobile/extenstion/ViewExt.kt 0.00% <ø> (ø)
...rg/edx/mobile/model/discussion/DiscussionThread.kt 0.00% <0.00%> (ø)
.../mobile/model/discussion/DiscussionTopicDepth.java 0.00% <0.00%> (ø)
...obile/src/main/java/org/edx/mobile/util/UiUtils.kt 0.00% <ø> (ø)
...mobile/view/CourseDiscussionPostsBaseFragment.java 0.00% <0.00%> (ø)
...bile/view/CourseDiscussionPostsSearchFragment.java 0.00% <0.00%> (ø)
...bile/view/CourseDiscussionPostsThreadFragment.java 0.00% <0.00%> (ø)
...mobile/view/CourseDiscussionResponsesFragment.java 0.00% <ø> (ø)
... and 8 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

HamzaIsrar12
HamzaIsrar12 suggested changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@HamzaIsrar12 HamzaIsrar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we are showing Lists in all cases, please use the ListAdapter as we did in CourseHomeAdapter and MyCoursesListAdapter.

OpenEdXMobile/res/layout/fragment_discussion_search_posts.xml Show resolved Hide resolved
OpenEdXMobile/res/layout/fragment_discussion_thread_posts.xml Show resolved Hide resolved
OpenEdXMobile/res/layout/fragment_discussion_topics.xml Outdated Show resolved Hide resolved
OpenEdXMobile/res/layout/row_discussion_topic.xml Outdated Show resolved Hide resolved
OpenEdXMobile/src/main/java/org/edx/mobile/extenstion/ImageViewExt.kt Outdated Show resolved Hide resolved
OpenEdXMobile/src/main/java/org/edx/mobile/view/CourseDiscussionPostsThreadFragment.java Outdated Show resolved Hide resolved
OpenEdXMobile/src/main/java/org/edx/mobile/view/CourseDiscussionPostsThreadFragment.java Outdated Show resolved Hide resolved
OpenEdXMobile/src/main/java/org/edx/mobile/view/CourseDiscussionTopicsFragment.java Outdated Show resolved Hide resolved
OpenEdXMobile/src/main/java/org/edx/mobile/view/CourseDiscussionTopicsFragment.java Outdated Show resolved Hide resolved
OpenEdXMobile/src/main/java/org/edx/mobile/view/CourseDiscussionTopicsFragment.java Outdated Show resolved Hide resolved
HamzaIsrar12
HamzaIsrar12 suggested changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@HamzaIsrar12 HamzaIsrar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits

OpenEdXMobile/src/main/java/org/edx/mobile/extenstion/ViewExt.kt Show resolved Hide resolved
OpenEdXMobile/src/main/java/org/edx/mobile/util/UiUtils.kt Show resolved Hide resolved
OpenEdXMobile/src/main/java/org/edx/mobile/model/discussion/DiscussionThread.kt Show resolved Hide resolved
OpenEdXMobile/src/main/java/org/edx/mobile/view/CourseDiscussionPostsThreadFragment.java Outdated Show resolved Hide resolved
OpenEdXMobile/src/main/java/org/edx/mobile/view/adapters/InfiniteScrollUtils.java Outdated Show resolved Hide resolved
OpenEdXMobile/src/main/java/org/edx/mobile/view/adapters/DiscussionTopicsAdapter.kt Outdated Show resolved Hide resolved
OpenEdXMobile/src/main/java/org/edx/mobile/view/adapters/DiscussionTopicsAdapter.kt Show resolved Hide resolved
OpenEdXMobile/src/main/java/org/edx/mobile/view/adapters/DiscussionTopicsAdapter.kt Show resolved Hide resolved
OpenEdXMobile/src/main/java/org/edx/mobile/view/adapters/DiscussionTopicsAdapter.kt Outdated Show resolved Hide resolved
OpenEdXMobile/src/main/java/org/edx/mobile/interfaces/ItemsComparator.kt Outdated Show resolved Hide resolved
HamzaIsrar12
HamzaIsrar12 suggested changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@HamzaIsrar12 HamzaIsrar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits.

In the meantime, I will perform a manual review to check for any discrepancies.

OpenEdXMobile/src/main/java/org/edx/mobile/view/CourseDiscussionPostsBaseFragment.java Outdated Show resolved Hide resolved
OpenEdXMobile/src/main/java/org/edx/mobile/view/CourseDiscussionPostsThreadFragment.java Outdated Show resolved Hide resolved
OpenEdXMobile/src/main/java/org/edx/mobile/view/adapters/DiscussionPostsAdapter.kt Outdated Show resolved Hide resolved
OpenEdXMobile/src/main/java/org/edx/mobile/view/adapters/DiscussionPostsAdapter.kt Outdated Show resolved Hide resolved
OpenEdXMobile/src/main/java/org/edx/mobile/view/adapters/DiscussionPostsAdapter.kt Outdated Show resolved Hide resolved
OpenEdXMobile/src/main/java/org/edx/mobile/view/adapters/DiscussionPostsAdapter.kt Outdated Show resolved Hide resolved
OpenEdXMobile/src/main/java/org/edx/mobile/view/adapters/DiscussionPostsAdapter.kt Outdated Show resolved Hide resolved
OpenEdXMobile/src/main/java/org/edx/mobile/view/adapters/DiscussionTopicsAdapter.kt Outdated Show resolved Hide resolved
HamzaIsrar12
HamzaIsrar12 approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@HamzaIsrar12 HamzaIsrar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏎️

@omerhabib26 omerhabib26 merged commit 36a0e15 into app_nav Sep 19, 2023
@omerhabib26 omerhabib26 deleted the omer/LEARNER-9578 branch September 19, 2023 09:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@HamzaIsrar12 HamzaIsrar12 HamzaIsrar12 approved these changes

@farhan-arshad-dev farhan-arshad-dev Awaiting requested review from farhan-arshad-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omerhabib26 @HamzaIsrar12