Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

fix: App Navigation Overhual #1823

Merged
merged 9 commits into from
Sep 25, 2023
Merged

fix: App Navigation Overhual #1823

merged 9 commits into from
Sep 25, 2023

Conversation

HamzaIsrar12
Copy link
Contributor

@HamzaIsrar12 HamzaIsrar12 commented Sep 20, 2023 •
edited
Loading

Description

LEARNER-9613

  • Course Unit Navigation Indicator
  • Download icon fluctuation on downloaded video deletion
  • Retain section visibility on refresh
  • Handle back press on Main and Course Dashboard
  • Handle the else case for the Course Dashboard
  • Enhance Course Navigation Buttons (Next & Previous)
  • Registration issue with Email after Incomplete Social Registration
  • Add Post Notification Permission

@HamzaIsrar12
fix: Add Post Notification Permission
df115af 
This was originally added as part of Learner-9361

Fixes: LEARNER-9613
@HamzaIsrar12
fix: Registration issue with Email after Incomplete Social
4d9f1c0 
Registration

In cases where a user initiates the social login process but does not
complete it and subsequently proceeds with email registration, the
application unexpectedly attempts to complete the initial social
registration using the access token and backend type from the
incomplete social registration. This fix addresses this issue.

Fixes: LEARNER-9613
@codecov
Copy link

codecov bot commented Sep 20, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (36a0e15) 1.09% compared to head (d3812fd) 1.09%.
Report is 1 commits behind head on app_nav.

❗ Current head d3812fd differs from pull request most recent head ea48dd9. Consider uploading reports for the commit ea48dd9 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff              @@
##             app_nav   #1823      +/-   ##
============================================
- Coverage       1.09%   1.09%   -0.01%     
  Complexity       137     137              
============================================
  Files            536     537       +1     
  Lines          25862   25933      +71     
  Branches        3296    3310      +14     
============================================
  Hits             284     284              
- Misses         25551   25622      +71     
  Partials          27      27
Files Changed Coverage Δ
...rg/edx/mobile/event/RefreshCourseDashboardEvent.kt 0.00% <0.00%> (ø)
...ain/java/org/edx/mobile/module/prefs/LoginPrefs.kt 0.00% <ø> (ø)
.../java/org/edx/mobile/view/CourseHomeTabFragment.kt 0.00% <0.00%> (ø)
...org/edx/mobile/view/CourseTabsDashboardFragment.kt 0.00% <0.00%> (ø)
...ava/org/edx/mobile/view/MainDashboardActivity.java 0.00% <ø> (ø)
...a/org/edx/mobile/view/MainTabsDashboardFragment.kt 0.00% <0.00%> (ø)
.../java/org/edx/mobile/view/MyCoursesListFragment.kt 0.00% <ø> (ø)
.../main/java/org/edx/mobile/view/RegisterActivity.kt 0.00% <0.00%> (ø)
.../org/edx/mobile/view/adapters/CourseHomeAdapter.kt 0.00% <0.00%> (ø)
...obile/view/app_nav/CourseUnitNavigationActivity.kt 0.00% <0.00%> (ø)
... and 1 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HamzaIsrar12 HamzaIsrar12 marked this pull request as ready for review September 21, 2023 11:44
@HamzaIsrar12 HamzaIsrar12 self-assigned this Sep 22, 2023
omerhabib26
omerhabib26 suggested changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@omerhabib26 omerhabib26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is working fine as mentioned, only minor code improvements need to be implemented.
Some other cases are:
1- Tapping behavior on CourseDashboard's Section and subsection can be improved.

OpenEdXMobile/res/layout/activity_course_unit_navigation.xml Show resolved Hide resolved
OpenEdXMobile/res/values/attrs.xml Outdated Show resolved Hide resolved
OpenEdXMobile/res/layout/fragment_dashboard_error_layout.xml Outdated Show resolved Hide resolved
OpenEdXMobile/src/main/java/org/edx/mobile/view/CourseTabsDashboardFragment.kt Outdated Show resolved Hide resolved
OpenEdXMobile/src/main/java/org/edx/mobile/view/adapters/CourseHomeAdapter.kt Outdated Show resolved Hide resolved
omerhabib26
omerhabib26 suggested changes Sep 24, 2023
View reviewed changes
Copy link
Contributor

@omerhabib26 omerhabib26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits need to be fixed

OpenEdXMobile/res/layout/activity_course_unit_navigation.xml Outdated Show resolved Hide resolved
OpenEdXMobile/src/main/java/org/edx/mobile/view/CourseTabsDashboardFragment.kt Outdated Show resolved Hide resolved
OpenEdXMobile/res/drawable/view_selector.xml Show resolved Hide resolved
OpenEdXMobile/res/layout/section_row_layout.xml Outdated Show resolved Hide resolved
OpenEdXMobile/res/layout/section_row_layout.xml Outdated Show resolved Hide resolved
OpenEdXMobile/src/main/java/org/edx/mobile/view/adapters/CourseHomeAdapter.kt Outdated Show resolved Hide resolved
OpenEdXMobile/src/main/java/org/edx/mobile/view/adapters/CourseHomeAdapter.kt Outdated Show resolved Hide resolved
OpenEdXMobile/src/main/java/org/edx/mobile/view/adapters/CourseHomeAdapter.kt Outdated Show resolved Hide resolved
omerhabib26
omerhabib26 approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@omerhabib26 omerhabib26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@HamzaIsrar12 HamzaIsrar12 merged commit 904deec into app_nav Sep 25, 2023
2 of 3 checks passed
@HamzaIsrar12 HamzaIsrar12 deleted the hamza/LEARNER-9613 branch September 25, 2023 08:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@omerhabib26 omerhabib26 omerhabib26 approved these changes

@farhan-arshad-dev farhan-arshad-dev Awaiting requested review from farhan-arshad-dev

Assignees

@HamzaIsrar12 HamzaIsrar12

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HamzaIsrar12 @omerhabib26