Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

fix: Discovery WebViews Issues #1828

Merged
merged 1 commit into from
Sep 28, 2023
Merged

fix: Discovery WebViews Issues #1828

merged 1 commit into from
Sep 28, 2023

Conversation

HamzaIsrar12
Copy link
Contributor

@HamzaIsrar12 HamzaIsrar12 commented Sep 28, 2023

Description

LEARNER-9636 | LEARNER-9637

  • Horizontal scrolling conflicted with vertical scrolling, causing pull-to-refresh issues.
  • WebViews were not functioning properly with data.
  • Back navigation did not work as expected in the webview.

Creating PR on behalf of @farhan-arshad-dev

- Horizontal scrolling conflicted with vertical scrolling, causing
 pull-to-refresh issues.
- WebViews were not functioning properly with data.
- Back navigation did not work as expected in the webview.

Fixes: LEARNER-9636 | LEARNER-9637
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Attention: 279 lines in your changes are missing coverage. Please review.

Comparison is base (6ef292f) 1.09% compared to head (ab50590) 1.08%.

Additional details and impacted files
@@             Coverage Diff             @@
##             master   #1828      +/-   ##
===========================================
- Coverage      1.09%   1.08%   -0.01%     
  Complexity      137     137              
===========================================
  Files           538     538              
  Lines         26044   26278     +234     
  Branches       3323    3377      +54     
===========================================
  Hits            284     284              
- Misses        25733   25967     +234     
  Partials         27      27              
Files Coverage Δ
...obile/view/custom/URLInterceptorWebViewClient.java 0.00% <ø> (ø)
...a/org/edx/mobile/view/WebViewDiscoverFragment.java 0.00% <0.00%> (ø)
.../org/edx/mobile/view/custom/NestedScrollWebView.kt 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@omerhabib26 omerhabib26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@HamzaIsrar12 HamzaIsrar12 merged commit bcf1d6d into master Sep 28, 2023
2 of 5 checks passed
@HamzaIsrar12 HamzaIsrar12 deleted the hamza/LEARNER-9636 branch September 28, 2023 22:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants