Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

Fix: Initialise button after adapter setup in UnitNavigationActivity #1832

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

omerhabib26
Copy link
Contributor

Description

LEARNER-9653

  • Initialise Navigation buttons after Pager Adapter initialisation on CourseUnitNavigation Activity

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (bcf1d6d) 1.08% compared to head (adaeee2) 1.08%.

Additional details and impacted files
@@           Coverage Diff            @@
##             master   #1832   +/-   ##
========================================
  Coverage      1.08%   1.08%           
  Complexity      137     137           
========================================
  Files           538     538           
  Lines         26293   26293           
  Branches       3381    3381           
========================================
  Hits            284     284           
  Misses        25982   25982           
  Partials         27      27           
Files Coverage Δ
...obile/view/app_nav/CourseUnitNavigationActivity.kt 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@farhan-arshad-dev farhan-arshad-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to reproduce this issue during the manual testing, so following the crash logs, and current code change looks appropriate to fix the crash.

@omerhabib26 omerhabib26 merged commit f9eaf0c into master Oct 9, 2023
2 of 5 checks passed
@omerhabib26 omerhabib26 deleted the omer/LEARNER-9653 branch October 9, 2023 11:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants