Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

feat: sink external user id #43

Merged
merged 2 commits into from
Sep 25, 2023
Merged

feat: sink external user id #43

merged 2 commits into from
Sep 25, 2023

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented Sep 22, 2023

Description: This PR implements a sink for the ExternalID model

Installation instructions: After configuring Aspects, you should run the following SQL in CLickhouse:

CREATE TABLE event_sink.external_id
(
    `external_user_id` UUID NOT NULL,
    `external_id_type` String,
    `user_id` Int32,
    `dump_id` UUID NOT NULL,
    `time_last_dumped` String NOT NULL
)
ENGINE = MergeTree
PRIMARY KEY (external_user_id, time_last_dumped)
ORDER BY (external_user_id, time_last_dumped)

Testing instructions:

  1. Open page A
  2. Do thing B
  3. Expect C to happen
  4. If D happened instead - check failed.

Reviewers:

  • tag reviewer
  • tag reviewer

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed

Post merge:

  • Create a tag
  • Check new version is pushed to PyPI after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)

Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.

@openedx-webhooks
Copy link

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 22, 2023
@bmtcril
Copy link
Contributor

bmtcril commented Sep 22, 2023

This will be good when you get that last bit of coverage. I created a new ticket in this repo for adding migrations.

@Ian2012 Ian2012 merged commit 9204077 into main Sep 25, 2023
@Ian2012 Ian2012 deleted the cag/sink-user-ids branch September 25, 2023 13:37
@openedx-webhooks
Copy link

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add external user ids to a sink
3 participants