Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add external id table #521

Merged
merged 1 commit into from
Nov 29, 2023
Merged

feat: add external id table #521

merged 1 commit into from
Nov 29, 2023

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented Nov 16, 2023

Description

This adds a table for the external_id sink defined here openedx-unsupported/openedx-event-sink-clickhouse#43

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 16, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@Ian2012 Ian2012 force-pushed the cag/create_external_id_table branch from 5b19b05 to ec991ab Compare November 16, 2023 22:19
@itsjeyd itsjeyd added core contributor PR author is a Core Contributor (who may or may not have write access to this repo). waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Nov 17, 2023
bmtcril
bmtcril reviewed Nov 17, 2023
View reviewed changes
tutoraspects/plugin.py Outdated Show resolved Hide resolved
@Ian2012 Ian2012 force-pushed the cag/create_external_id_table branch from 64d2841 to bcd308f Compare November 17, 2023 20:11
@Ian2012 Ian2012 requested a review from bmtcril November 22, 2023 16:03
@itsjeyd itsjeyd added waiting for eng review PR is ready for review. Review and merge it, or suggest changes. and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Nov 23, 2023
@pomegranited pomegranited mentioned this pull request Nov 28, 2023
Closed
@pomegranited pomegranited mentioned this pull request Nov 29, 2023
Merged
2 tasks
pomegranited
pomegranited approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ian2012 👍 with a couple of suggestions (inline).

  • I tested this on my tutor dev stack with ASPECTS_ENABLE_PII=True. New users' external_user_id records are saved to the event_sink.external_id table as expected.
  • I read through the code
  • I checked for accessibility issues N/A
  • Includes documentation N/A
  • User-facing strings are extracted for translation N/A

...ts/templates/aspects/apps/aspects/migrations/alembic/versions/0026_event_sink_external_id.py Show resolved Hide resolved
@itsjeyd itsjeyd added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed waiting for eng review PR is ready for review. Review and merge it, or suggest changes. labels Nov 29, 2023
@Ian2012
feat: add external id table
3c50bd7 
fix: add missing external_id to list of models

fix: add username for event sink

chore: reformat for quality checks
@Ian2012 Ian2012 force-pushed the cag/create_external_id_table branch from bcd308f to 3c50bd7 Compare November 29, 2023 16:11
@Ian2012
Copy link
Contributor Author

Ian2012 commented Nov 29, 2023

@pomegranited thanks for the review, I've updated the definition

@Ian2012 Ian2012 merged commit ceeb4e6 into main Nov 29, 2023
6 checks passed
@Ian2012 Ian2012 deleted the cag/create_external_id_table branch November 29, 2023 17:21
@openedx-webhooks
Copy link

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd itsjeyd removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pomegranited pomegranited pomegranited approved these changes

@bmtcril bmtcril Awaiting requested review from bmtcril

Assignees
No one assigned
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ian2012 @openedx-webhooks @pomegranited @bmtcril @itsjeyd