Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft for wallet attestation #408

Merged
merged 21 commits into from
Dec 12, 2024
Merged

Draft for wallet attestation #408

merged 21 commits into from
Dec 12, 2024

Conversation

paulbastian
Copy link
Contributor

@paulbastian paulbastian commented Oct 28, 2024 •
edited
Loading

Closes #355
Closes #406

  • JWT format
  • References in Token Request?

@Sakurann
Copy link
Collaborator

Sakurann commented Oct 28, 2024 •
edited
Loading

can this PR also address #150 ?
and might be worth looking into #366 and #44 jfyi

David-Chadwick
David-Chadwick reviewed Nov 12, 2024
View reviewed changes
Copy link
Contributor

@David-Chadwick David-Chadwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see anywhere in this draft that says that the wallet attestation should be displayable to the user, as a means of engendering the user's trust in the wallet app. The current text is concerned with transferring the wallet attestation between system components, which is important. But so is display to the user.

@paulbastian
Copy link
Contributor Author

@pmhsfelix Torsten and I simplified the text a lot, please have a look

c2bo
c2bo approved these changes Dec 6, 2024
View reviewed changes
openid-4-verifiable-credential-issuance-1_0.md Outdated Show resolved Hide resolved
openid-4-verifiable-credential-issuance-1_0.md Outdated Show resolved Hide resolved
@paulbastian @peppelinux
Apply suggestions from code review
e7f7105 
Co-authored-by: Giuseppe De Marco <[email protected]>
@peppelinux peppelinux mentioned this pull request Dec 12, 2024
Open
@Sakurann Sakurann merged commit 3a83d47 into main Dec 12, 2024
1 of 2 checks passed
@c2bo c2bo mentioned this pull request Dec 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sakurann Sakurann Sakurann approved these changes

@c2bo c2bo c2bo approved these changes

@David-Chadwick David-Chadwick David-Chadwick approved these changes

@peppelinux peppelinux peppelinux approved these changes

@tlodderstedt tlodderstedt tlodderstedt approved these changes

@danielfett danielfett Awaiting requested review from danielfett

@jogu jogu Awaiting requested review from jogu

@pmhsfelix pmhsfelix Awaiting requested review from pmhsfelix

@samuelgoto samuelgoto Awaiting requested review from samuelgoto

@selfissued selfissued Awaiting requested review from selfissued

@awoie awoie Awaiting requested review from awoie

@bc-pi bc-pi Awaiting requested review from bc-pi

@babisRoutis babisRoutis Awaiting requested review from babisRoutis

@tplooker tplooker Awaiting requested review from tplooker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

define how is wallet attestation used with VCI Issuer Trust Evidence / key attestations for OpenID4VCI
9 participants
@paulbastian @Sakurann @c2bo @pmhsfelix @TomCJones @tlodderstedt @peppelinux @David-Chadwick @tplooker