second attempt to add sd-jwt vcdm #147
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alenhorvat
reviewed
Dec 19, 2024
| { | ||
| "vct": "https://credentials.example.com/identity_credential", | ||
| //W3C VCDM 2.0 compliant claims | ||
| "vcdm": { |
alenhorvat
reviewed
Dec 19, 2024
| //W3C VCDM 2.0 compliant claims | ||
| "vcdm": { | ||
| "@context": ["https://www.w3.org/ns/credentials/v2"], | ||
| "type": ["VerifiableCredential", "https://credentials.example.com/identity_credential"], |
There was a problem hiding this comment.
should be top level and relationship with vct must be explained
alenhorvat
reviewed
Dec 19, 2024
| For backward compatibility with JWT processors, the following registered JWT claims MUST be used, instead of their respective counterpart properties in [@!W3C.VCDM1.1] or [@!W3C.VCDM2.0]: | ||
|
|
||
| * `exp` Claim MUST represent the `expirationDate` property, encoded as a UNIX timestamp (NumericDate). | ||
| * `iss` Claim MUST represent the `issuer` property. |
There was a problem hiding this comment.
issuer can be an object; IMO usage of iss/issuer must be properly explained as self-declared and unverifiable claims should not be used.
alenhorvat
reviewed
Dec 19, 2024
| * `exp` Claim MUST represent the `expirationDate` property, encoded as a UNIX timestamp (NumericDate). | ||
| * `iss` Claim MUST represent the `issuer` property. | ||
| * `iat` Claim MUST represent `issuanceDate` property, encoded as a UNIX timestamp (NumericDate). | ||
| * `status` Claim MUST represent `credentialStatus` property. |
There was a problem hiding this comment.
Do you confirm that status and credential status have the same governance model? So, it contains a "type" property that defines which revocation/suspension mechanism is used?
alenhorvat
reviewed
Dec 19, 2024
| * `iss` Claim MUST represent the `issuer` property. | ||
| * `iat` Claim MUST represent `issuanceDate` property, encoded as a UNIX timestamp (NumericDate). | ||
| * `status` Claim MUST represent `credentialStatus` property. | ||
| * `schema` Claim MUST represent the `credentialSchema` property. |
There was a problem hiding this comment.
Same question as for status; Note: ELM is using 2: JSON schema and SHACL schema.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #128
intended as an altenative that supercedes #134