Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8336499: Failure when creating non-CRT RSA private keys in SunPKCS11 #2979

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sorna-Sarathi
Copy link

@Sorna-Sarathi Sorna-Sarathi commented Oct 21, 2024

Hi all,
This pull request contains a backport of commit 3251eea from the openjdk/jdk repository.
I've also resolved a build failure with the latest version of gtest(In JDK17) by backporting the fix.
Thanks!

JBS Issue: JDK-8336499


Progress

  • Change must not contain extraneous whitespace
  • JDK-8336499 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8336499: Failure when creating non-CRT RSA private keys in SunPKCS11 (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2979/head:pull/2979
$ git checkout pull/2979

Update a local copy of the PR:
$ git checkout pull/2979
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2979/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2979

View PR using the GUI difftool:
$ git pr show -t 2979

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2979.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Oct 21, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 21, 2024

Hi @Sorna-Sarathi, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user Sorna-Sarathi" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Oct 21, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 3251eea1f4289a0505052be204407c02ca38b0ad 8336499: Failure when creating non-CRT RSA private keys in SunPKCS11 Oct 21, 2024
@openjdk
Copy link

openjdk bot commented Oct 21, 2024

This backport pull request has now been updated with issue from the original commit.

@Sorna-Sarathi
Copy link
Author

/covered

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Oct 21, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 21, 2024

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Oct 22, 2024
@openjdk
Copy link

openjdk bot commented Oct 22, 2024

⚠️ @Sorna-Sarathi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 22, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 22, 2024

Webrevs

@offamitkumar
Copy link
Member

Here also, GHA is not enabled.

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 20, 2024

@Sorna-Sarathi This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@Sorna-Sarathi
Copy link
Author

/approval request fixes failure when creating non-CRT RSA private keys in SunPKCS11. Backporting it.

@openjdk
Copy link

openjdk bot commented Nov 20, 2024

@Sorna-Sarathi
8336499: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Nov 20, 2024
@openjdk openjdk bot removed the approval label Dec 12, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 18, 2024

@Sorna-Sarathi This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants