Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315883: Open source several Swing JToolbar tests #3155

Closed

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Dec 20, 2024

I backport this for parity with 17.0.15-oracle.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8315883 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8315883: Open source several Swing JToolbar tests (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3155/head:pull/3155
$ git checkout pull/3155

Update a local copy of the PR:
$ git checkout pull/3155
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3155/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3155

View PR using the GUI difftool:
$ git pr show -t 3155

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3155.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 20, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 20, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315883: Open source several Swing JToolbar tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 247815b: 8325937: runtime/handshake/HandshakeDirectTest.java causes "monitor end should be strictly below the frame pointer" assertion failure on AArch64
  • 10ea45e: 8316149: Open source several Swing JTree JViewport KeyboardManager tests
  • d9aa705: 8315952: Open source several Swing JToolbar JTooltip JTree tests

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 62c0a1b9ac6462233f3ee06af470be9844e9e226 8315883: Open source several Swing JToolbar tests Dec 20, 2024
@openjdk
Copy link

openjdk bot commented Dec 20, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 20, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 20, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 20, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Dec 22, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Dec 24, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Dec 24, 2024

Going to push as commit 409158e.
Since your change was applied there have been 4 commits pushed to the master branch:

  • a35aef8: 8316056: Open source several Swing JTree tests
  • 247815b: 8325937: runtime/handshake/HandshakeDirectTest.java causes "monitor end should be strictly below the frame pointer" assertion failure on AArch64
  • 10ea45e: 8316149: Open source several Swing JTree JViewport KeyboardManager tests
  • d9aa705: 8315952: Open source several Swing JToolbar JTooltip JTree tests

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 24, 2024
@openjdk openjdk bot closed this Dec 24, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 24, 2024
@openjdk
Copy link

openjdk bot commented Dec 24, 2024

@GoeLin Pushed as commit 409158e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant