Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8343882: BasicAnnoTests doesn't handle multiple annotations at the same position #3158

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Dec 21, 2024

Hi all,

This pull request contains a backport of commit d562d3c7 from the openjdk/jdk repository. Test-fix only, change has been verified locally, no risk.

The commit being backported was authored by Liam Miller-Cushon on 20 Dec 2024 and was reviewed by Joe Darcy.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • JDK-8343882 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8343882: BasicAnnoTests doesn't handle multiple annotations at the same position (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3158/head:pull/3158
$ git checkout pull/3158

Update a local copy of the PR:
$ git checkout pull/3158
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3158/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3158

View PR using the GUI difftool:
$ git pr show -t 3158

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3158.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 21, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 21, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport d562d3c7a9e1e857c095ef908b0957b033972949 8343882: BasicAnnoTests doesn't handle multiple annotations at the same position Dec 21, 2024
@openjdk
Copy link

openjdk bot commented Dec 21, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 21, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 21, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 21, 2024

Webrevs

@sendaoYan
Copy link
Member Author

GHA report 2 failures:

  1. Job linux-x64-hs-minimal fails at Get JTReg stage, report wget exited with exit code 4, seems like infrastructure or environmental issue, it's unrelated this PR.
  2. Job linux-x64-hs-optimized fails at Get JTReg stage, report wget exited with exit code 4, seems like infrastructure or environmental issue, it's unrelated this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant