8342609: jpackage test helper function incorrectly removes a directory instead of its contents only #3165
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I backport this for parity with 21.0.7-oracle.
17 has the same issue.
Resolved Copyright, probably clean anyways.
Progress
Warning
8342609: jpackage test helper function incorrectly removes a directory instead of its contents only
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3165/head:pull/3165
$ git checkout pull/3165
Update a local copy of the PR:
$ git checkout pull/3165
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3165/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3165
View PR using the GUI difftool:
$ git pr show -t 3165
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3165.diff
Using Webrev
Link to Webrev Comment