Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8342609: jpackage test helper function incorrectly removes a directory instead of its contents only #3165

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Dec 23, 2024

I backport this for parity with 21.0.7-oracle.
17 has the same issue.

Resolved Copyright, probably clean anyways.


Progress

  • JDK-8342609 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8342609: jpackage test helper function incorrectly removes a directory instead of its contents only

Issue

  • JDK-8342609: jpackage test helper function incorrectly removes a directory instead of its contents only (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3165/head:pull/3165
$ git checkout pull/3165

Update a local copy of the PR:
$ git checkout pull/3165
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3165/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3165

View PR using the GUI difftool:
$ git pr show -t 3165

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3165.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 23, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 23, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 7133d1b983d7b85ba3c8dde26eb654c7ab695b07 8342609: jpackage test helper function incorrectly removes a directory instead of its contents only Dec 23, 2024
@openjdk
Copy link

openjdk bot commented Dec 23, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Dec 23, 2024
@GoeLin GoeLin force-pushed the goetz_backport_8342609 branch from 06ebf6c to 0a9f55c Compare December 23, 2024 14:37
@openjdk
Copy link

openjdk bot commented Dec 23, 2024

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot added the clean label Dec 23, 2024
@openjdk
Copy link

openjdk bot commented Dec 23, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 23, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 23, 2024

Webrevs

@openjdk openjdk bot added the approval label Dec 24, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Dec 24, 2024

GHA failure: well konwn wget issue, unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant