Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8339883: Open source several AWT/2D related tests #3166

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Dec 23, 2024

I backport this for parity with 17.0.15-oracle.


Progress

  • JDK-8339883 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8339883: Open source several AWT/2D related tests (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3166/head:pull/3166
$ git checkout pull/3166

Update a local copy of the PR:
$ git checkout pull/3166
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3166/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3166

View PR using the GUI difftool:
$ git pr show -t 3166

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3166.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 23, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 23, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport b26645f64bb6dd3efafaceb92bedeaf8f93906e3 8339883: Open source several AWT/2D related tests Dec 23, 2024
@openjdk
Copy link

openjdk bot commented Dec 23, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 23, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 23, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 23, 2024

Webrevs

@openjdk openjdk bot added the approval label Dec 24, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Dec 24, 2024

GHA failure: Twice well konwn wget issue, unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant