Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add start script handling for Distributions tasks #127

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

arlaneenalra
Copy link

This code does two things:

  • Adds code to handle updating CreateStartScripts configuration in the same way that the JavaExec task is updated. This allows the assembleDist task to create usable startup scripts.
  • Updates the build to gradle 7.4.2 (Mainly because I only have access to an M1 Mac and can't build with gradle 5.5.1)

To accomplish this, I abstracted the common behavior in ExecTask into a JavaFXTask base class and added the StartScriptsTask. This is probably not the cleanest implementation but it appears to work in my local testing.

It may be possible to back out the gradle update, but I would have no way to test that.

@arlaneenalra
Copy link
Author

@jperedadnr or @abhinayagarwal my apologies if this is a breach of protocol, what's the best way to get reviewers for a pull request?

@sschuberth
Copy link

This PR has conflicts now that #151 was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants