Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapshot logic #1434

Merged
merged 11 commits into from
Nov 16, 2023
Merged

Snapshot logic #1434

merged 11 commits into from
Nov 16, 2023

Conversation

egdmrsy
Copy link
Contributor

@egdmrsy egdmrsy commented Jul 31, 2023 •
edited
Loading

…s and workflows.

Checklist

  • I have followed (at least) the PR section of the contributing guide.
  • I fixed all necessary PR warnings
  • The commit history is clean
  • The E2E tests are passing
  • If possible, the issue has been divided into more subtasks
  • I did a self review before requesting a review from another team member

Description

Closes #1108

@egdmrsy egdmrsy force-pushed the 1108-api-heap-and-cache-problems branch from 784679c to a973ee7 Compare July 31, 2023 14:33
@github-actions
Copy link

github-actions bot commented Jul 31, 2023 •
edited
Loading

Warnings
⚠️ One of the resource files in the api domain layer (project.ts/subproject.ts/workflowitem.ts) were edited. If a new property was added the excel-export project has to be adapted.

Generated by 🚫 dangerJS against 075a048

@openkfwCI
Copy link

openkfwCI commented Jul 31, 2023 •
edited
Loading

NotesTime
✅Note for Reviewer: E2E tests on remote server succeededThu, 16 Nov 2023 10:32:36 +0000

Generated by E2E-Test

@egdmrsy egdmrsy force-pushed the 1108-api-heap-and-cache-problems branch from 4f90704 to fc82e2d Compare August 3, 2023 13:00
@egdmrsy egdmrsy force-pushed the 1108-api-heap-and-cache-problems branch 2 times, most recently from 813885d to 973ac14 Compare September 22, 2023 13:34
@egdmrsy egdmrsy self-assigned this Sep 25, 2023
@egdmrsy egdmrsy requested a review from georgimld September 26, 2023 07:20
@egdmrsy egdmrsy force-pushed the 1108-api-heap-and-cache-problems branch from 973ac14 to 321139e Compare October 4, 2023 07:53
@egdmrsy egdmrsy marked this pull request as ready for review October 5, 2023 07:52
@egdmrsy egdmrsy force-pushed the 1108-api-heap-and-cache-problems branch from 1b4d525 to aa9aa9b Compare October 9, 2023 08:05
@mayrmartin mayrmartin self-requested a review October 18, 2023 11:12
mayrmartin
mayrmartin requested changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@mayrmartin mayrmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some documentation on how the caching works in the TruBudet Architecture documentation.

api/src/service/cache_snapshot.ts Outdated Show resolved Hide resolved
api/src/service/cache_snapshot.ts Show resolved Hide resolved
api/src/service/cache_snapshot.ts Outdated Show resolved Hide resolved
api/src/service/cache_snapshot.ts Outdated Show resolved Hide resolved
api/src/service/cache_snapshot.ts Outdated Show resolved Hide resolved
api/src/service/subproject_cache_helper.ts Outdated Show resolved Hide resolved
api/src/service/subproject_history_get.ts Outdated Show resolved Hide resolved
api/src/service/workflowitem_cache_helper.ts Outdated Show resolved Hide resolved
api/src/service/workflowitem_cache_helper.ts Outdated Show resolved Hide resolved
api/src/service/workflowitem_history_get.ts Outdated Show resolved Hide resolved
mayrmartin
mayrmartin requested changes Nov 6, 2023
View reviewed changes
api/src/service/cache_snapshot.ts Outdated Show resolved Hide resolved
api/src/service/cache_snapshot.ts Outdated Show resolved Hide resolved
api/src/service/cache_snapshot.ts Outdated Show resolved Hide resolved
api/src/service/cache_snapshot.ts Outdated Show resolved Hide resolved
api/src/service/cache_snapshot.ts Outdated Show resolved Hide resolved
api/src/service/cache_snapshot.ts Outdated Show resolved Hide resolved
api/src/service/cache_snapshot.ts Outdated Show resolved Hide resolved
api/src/service/cache_snapshot.ts Outdated Show resolved Hide resolved
api/src/service/cache_snapshot.ts Outdated Show resolved Hide resolved
api/src/service/cache_snapshot.ts Outdated Show resolved Hide resolved
@egdmrsy egdmrsy force-pushed the 1108-api-heap-and-cache-problems branch from 9c2ff31 to 5f42dc2 Compare November 7, 2023 12:26
@egdmrsy egdmrsy requested review from SamuelPull and removed request for georgimld November 7, 2023 12:27
@SamuelPull
Copy link
Collaborator

Are there any requirements for backward compatibility? Did we test if this could be an issue?

@egdmrsy egdmrsy force-pushed the 1108-api-heap-and-cache-problems branch from 4f479f1 to 091c907 Compare November 15, 2023 12:28
egdmrsy added 10 commits November 16, 2023 12:25
@egdmrsy egdmrsy force-pushed the 1108-api-heap-and-cache-problems branch from 091c907 to 075a048 Compare November 16, 2023 09:25
@egdmrsy egdmrsy merged commit 9264099 into main Nov 16, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelPull SamuelPull SamuelPull left review comments

@mayrmartin mayrmartin mayrmartin approved these changes

Assignees

@egdmrsy egdmrsy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API heap and cache problems SP 8
4 participants
@egdmrsy @openkfwCI @SamuelPull @mayrmartin