adding additional endpoint to get the latest 10 timestamps #2076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galethil
requested changes
Nov 22, 2024
api/src/httpd/router.ts
Outdated
| @@ -280,6 +281,21 @@ export const registerRoutes = ( | |||
| }, | |||
| ); | |||
|
|
|||
| server.get( | |||
| `${urlPrefix}/timestaps`, | |||
There was a problem hiding this comment.
@amha-mersha there is a typo in the endpoint name
api/src/httpd/router.ts
Outdated
| @@ -280,6 +281,21 @@ export const registerRoutes = ( | |||
| }, | |||
| ); | |||
|
|
|||
| server.get( | |||
| `${urlPrefix}/timestaps`, | |||
| silentRouteSettings(getSchema(server, "version")), | |||
There was a problem hiding this comment.
@amha-mersha you have not defined the schema. You have to use correct name the schema of endpoint and also create it in api/src/httpd/schema.ts file and describe request and response schema there.
Suggested change
| silentRouteSettings(getSchema(server, "version")), | |
| silentRouteSettings(getSchema(server, "timestamps")), |
amha-mersha
force-pushed
the
amha.additional_api
branch
from
99abbe3 to
8af49c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
How to test
I tried to add the enpoint for the issue number #1965