Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate istio destinationRule subset from pod-template-hash #212

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

myname4423
Copy link
Contributor

@myname4423 myname4423 commented Apr 10, 2024

... and add fields to allow user set canary/stable subset name

Ⅰ. Describe what this PR does

Behaviors if this PR merged:

  1. when work with Istio for trafficRouting, if spec.strategy.canary.disableGenerateCanaryService is set true and Istio DestinationRule is provided, Rollout will append a canary subset for DestinationRule. The stable subset(if not provided in DestinationRule, stable subset will be create also) and canary subset are distinguished by label selectors, which are respectively pod-template-hash of v1 and v2.

  2. User is allowed to set subset name of stable subset and canary subset, via spec.strategy.canary.trafficRoutings[x].additionalParams, such as

      trafficRoutings:
      - customNetworkRefs: 
        - apiVersion: networking.istio.io/v1beta1
          kind: DestinationRule
          name: dr-demo
        - apiVersion: networking.istio.io/v1beta1
          kind: VirtualService
          name: vs-demo
        service: service-demo
        additionalParams:
          istio.destinationRule.stableSubsetName: "base" # defaults to "stable"
          istio.destinationRule.canarySubsetName: "canary" # defaults to "canary"

Ⅱ. Does this pull request fix one issue?

no

Ⅲ. Special notes for reviews

will update doc later

…ields to allow user set canary/stable subset name

Signed-off-by: yunbo <[email protected]>
@kruise-bot kruise-bot requested review from FillZpp and veophi April 10, 2024 02:01
@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign furykerry for approval by writing /assign @furykerry in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot added size/XL and removed size/L labels Apr 10, 2024
@kruise-bot
Copy link

@myname4423: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants