Patch rollout-batch-id even without rollout-id in workload #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PersistentJZH
force-pushed
the
zhihao/fix/fix-patch-rollout-batch-id
branch
from
a702034 to
84a0e60
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #248 +/- ##
==========================================
- Coverage 45.55% 44.95% -0.60%
==========================================
Files 57 61 +4
Lines 6395 7002 +607
==========================================
+ Hits 2913 3148 +235
- Misses 2989 3309 +320
- Partials 493 545 +52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: zhihao jian <[email protected]>
PersistentJZH
force-pushed
the
zhihao/fix/fix-patch-rollout-batch-id
branch
from
84a0e60 to
eb69d8d
Compare
|
simply use revision id may not works for rollback cases, rollback also support mutli-batch rollback. |
can you give me a specific scenario so I can reproduce it? maybe can use the SafeEncodeString func to encode the revision id. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
#244
Ⅲ. Special notes for reviews