Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks for Subscription dependencies so they cannot be updated inconsistently #1981

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

GAlexIHU
Copy link
Contributor

@GAlexIHU GAlexIHU commented Dec 17, 2024

Overview

  • Disallow updating custom UsageAttribution if a Subscription is present
  • Disallow archiving features used in active or scheduled plans or subscriptions

Notes for reviewer

  • Due to how features are currently linked in plans & subscriptions, logically speaking a feature can rarely be archived once its used in the productcatalog/subscription subsystem. I added a ticket to clean this up at a later point (might even make sense to do away with "archiving" for features)

@GAlexIHU GAlexIHU added the release-note/misc Miscellaneous changes label Dec 17, 2024
@GAlexIHU GAlexIHU requested a review from hekike December 17, 2024 16:04
@GAlexIHU GAlexIHU changed the title fix(subs): disallow updating customer UsageAttribution is a Subscript… Add checks for Subscription Dependencies so they cannot be updated inconsistently Dec 17, 2024
@GAlexIHU GAlexIHU marked this pull request as ready for review December 17, 2024 16:55
@GAlexIHU GAlexIHU changed the title Add checks for Subscription Dependencies so they cannot be updated inconsistently Add checks for Subscription dependencies so they cannot be updated inconsistently Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc Miscellaneous changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant