-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display and install dependencies #22
base: master
Are you sure you want to change the base?
Conversation
Looks awesome! Before I dive into the code for this, I have a couple thoughts that immediately come to mind that I think should be discussed in one way or another:
For the API, I will have to implement a new API to get numeric ID's from identifiers, much like how the update check currently works (you can pass multiple numeric ID's to get results on multiple plugins). |
That's an oversight on my part, it's an easy fix tho so no biggie!
Yeah, I'm thinking maybe instead of
I was thinking maybe it could be a popup that appears when a plugin has unmet mandatory deps, but also having a way to access it manually for optional dependencies would be nice. I could do some mockups of UI ideas but it's certainly not my strong suit so 😛
that'd be pretty poggers, maybe something like |
I think it shouldn't show the
I think that makes sense. I'm not sure where the menu for this would be located though. Either in the main menu (which might be too much clutter) or we create a new menu in the plugin manager window (which might only be 1 singular option, and that might be kind of a waste of space).
Yeah, something like that. I'll let you know about the actual API when it's implemented. |
Pushed some more fixes to take advantage of the website api changes in the pipeline. This vastly reduces the overhead caused by the Dependency Manager, as well as adds dependent plugin info to the PluginTab ui: The Install button has also been adjusted to automatically install any required dependencies automatically, with a tooltip indicating as such. |
This isn't quite a fix for #6, but I think it's a good middle point until such time as the API supports dependency autoinstalls.
(That being said, I'm pretty sure you could auto-install dependencies without changing the API. It'd be a little jank, but you could store the ident of the plugin you're trying to install, then if it fails, see which
.Dependencies
aren't present. I was considering writing this, but I suspect we'd prefer a more elegant approach. If we wanted to do this, the dep manager pulls all the data to facilitate it)One item of note is due to API limitations I'm making a few requests to /api/plugins (one for each page). If there was a way to get all items at once, that might make more sense for this. IDK what the server-side limitations are tho.