FEAT: Flat file policies #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also a start to the upcoming refactoring. The `Profile` and `Rule` classes now check `OpenDocument` objects rather than `OdfPackage` or `OdfXmlDocument` objects. This is a step towards the upcoming refactoring where the `OpenDocument` class will be the main class for handling OpenDocument files. - `Profile` and `Rule` now check `OpenDocument` objects rather than `OdfPackage` or `OdfXmlDocument` objects; - sensible flat file implementations now added for all policies (this still means returning an empty message list for some that are package exclusive); - `OpenDocument` now has a `Path` attribute and instantiation now requires a `Path` object; - added a `path` attribute to the `ZipArchive` so that tracing a documents source is easier; - updated version of commons-compress to 1.27.1; - replaced deprecated `ZipFile` constructors with `ZipFile.Builder` instantiation; and - refactored some test duplication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also a start to the upcoming refactoring. The
ProfileandRuleclasses now checkOpenDocumentobjects rather thanOdfPackageorOdfXmlDocumentobjects. This is a step towards the upcoming refactoring where theOpenDocumentclass will be the main class for handling OpenDocument files.ProfileandRulenow checkOpenDocumentobjects rather thanOdfPackageorOdfXmlDocumentobjects;OpenDocumentnow has aPathattribute and instantiation now requires aPathobject;pathattribute to theZipArchiveso that tracing a documents source is easier;ZipFileconstructors withZipFile.Builderinstantiation; and