FIX: RHIs now work with Halo Photonics Reader

[rcjackson]

This fixes the error shown in PR #247 when an RHI was being loaded by the Halo Photonics reader.

• Closes TypeError: only integer scalar arrays can be converted to a scalar index #247
• Changes are documented in history.md

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.64%. Comparing base (b4684fa) to head (ef67a30).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
+ Coverage   93.49%   93.64%   +0.14%     
==========================================
  Files          26       26              
  Lines        5028     5032       +4     
==========================================
+ Hits         4701     4712      +11     
+ Misses        327      320       -7     

Flag	Coverage Δ
notebooktests	78.97% <55.55%> (-0.05%)	⬇️
unittests	93.22% <100.00%> (+0.14%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mgrover1]

One slight suggestion - can you add a quick test here to hit those thresholds?

[rcjackson]

One slight suggestion - can you add a quick test here to hit those thresholds?

I've added a PR to open-radar-data for a Halo Photonics RHI file to make the test. Once that PR is approved and open-radar-data is updated, I can add a test for the RHI file.

[zssherman]

@rcjackson I approved the PR and got a release going so the open-radar-data repo once it releases on conda-forge should be good to go.

[rcjackson]

@rcjackson I approved the PR and got a release going so the open-radar-data repo once it releases on conda-forge should be good to go.

Ok it looks like we're just waiting for the release to conda-forge to get the tests passing. I added 2 tests for reading from an IOBase and from an RHI file, so that should improve the metrics.

[mgrover1]

This looks fantastic - thanks for all the hard work here @rcjackson , especially adding the example and tests here! 🎉

[mgrover1]

Since the tests now require the newest version of open-radar-data, I updated that version in the CI suite